Skip to content

Add rustdoc JS non-std tests #58330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 12, 2019
Merged

Add rustdoc JS non-std tests #58330

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
834347d
Add rustdoc JS non-std tests
GuillaumeGomez Feb 9, 2019
aa3ca32
Rename rustdoc js test suites
GuillaumeGomez Feb 23, 2019
be23cd9
Move documentation build into bootstrap
GuillaumeGomez Feb 24, 2019
240fad0
Update to last updates
GuillaumeGomez Feb 25, 2019
405d950
Move rustdoc-js testing into compiletest
GuillaumeGomez Feb 28, 2019
d6add90
Improve code
GuillaumeGomez Mar 6, 2019
37ab3dc
Make js tests work even with resource-suffix option
GuillaumeGomez Mar 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improve code
  • Loading branch information
@GuillaumeGomez
GuillaumeGomez committed Mar 6, 2019
commit d6add90c64a27de32a63b933f8f03d0c53fca4d0
5 changes: 4 additions & 1 deletion src/tools/compiletest/src/runtest.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,8 @@ impl<'test> TestCx<'test> {
fn should_compile_successfully(&self) -> bool {
match self.config.mode {
CompileFail => self.props.compile_pass,
RunPass | JsDocTest => true,
RunPass => true,
JsDocTest => true,
Ui => self.props.compile_pass,
Incremental => {
let revision = self.revision
Expand Down Expand Up @@ -2728,6 +2729,8 @@ impl<'test> TestCx<'test> {
if !res.status.success() {
self.fatal_proc_rec("rustdoc-js test failed!", &res);
}
} else {
self.fatal("no nodeJS");
}
}

Expand Down