Skip to content

Set secure flags when opening a named pipe on Windows #58216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 2, 2019
Merged

Set secure flags when opening a named pipe on Windows #58216

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
503e74e
Fix SECURITY_SQOS_PRESENT missing
pitdicker Feb 6, 2019
089524c
Correct OpenOptions::security_qos_flags documentation
pitdicker Feb 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix SECURITY_SQOS_PRESENT missing 
if security_qos_flags(SECURITY_ANONYMOUS) is set
  • Loading branch information
@pitdicker
pitdicker committed Feb 15, 2019
commit 503e74e96958045025448f90c8da4c7bd1484be9
7 changes: 5 additions & 2 deletions src/libstd/sys/windows/fs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,11 @@ impl OpenOptions {
pub fn access_mode(&mut self, access_mode: u32) { self.access_mode = Some(access_mode); }
pub fn share_mode(&mut self, share_mode: u32) { self.share_mode = share_mode; }
pub fn attributes(&mut self, attrs: u32) { self.attributes = attrs; }
pub fn security_qos_flags(&mut self, flags: u32) { self.security_qos_flags = flags; }
pub fn security_qos_flags(&mut self, flags: u32) {
// We have to set `SECURITY_SQOS_PRESENT` here, because one of the valid flags we can
// receive is `SECURITY_ANONYMOUS = 0x0`, which we can't check for later on.
self.security_qos_flags = flags | c::SECURITY_SQOS_PRESENT;
}
pub fn security_attributes(&mut self, attrs: c::LPSECURITY_ATTRIBUTES) {
self.security_attributes = attrs as usize;
}
Expand Down Expand Up @@ -239,7 +243,6 @@ impl OpenOptions {
self.custom_flags |
self.attributes |
self.security_qos_flags |
if self.security_qos_flags != 0 { c::SECURITY_SQOS_PRESENT } else { 0 } |
if self.create_new { c::FILE_FLAG_OPEN_REPARSE_POINT } else { 0 }
}
}
Expand Down