Skip to content

Be more permissive with required bounds on existential types #57896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 19, 2019
Merged

Be more permissive with required bounds on existential types #57896

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
381c541
Add FIXME
oli-obk Jan 25, 2019
6982fd2
Be more permissive with required bounds on existential types
oli-obk Jan 25, 2019
ed10a5b
Test all the things
oli-obk Jan 25, 2019
0d25ff8
Test aller things
oli-obk Jan 25, 2019
cf01b51
Generic type parameters are flexible even for existential types
oli-obk Jan 25, 2019
6f83dcc
Restrict concrete types to equivalent types
oli-obk Jan 29, 2019
984688a
Test more related cases
oli-obk Jan 29, 2019
f2241f6
Make the existential type errors a little bit more helpful
oli-obk Jan 29, 2019
c93bce8
Add more tests
oli-obk Feb 5, 2019
eb98d31
Require defining uses to use generic parameters for all parameters of…
oli-obk Feb 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add FIXME
  • Loading branch information
@oli-obk
oli-obk committed Feb 1, 2019
commit 381c5416855f53e130d5156aec5f9067fc981dfa
2 changes: 2 additions & 0 deletions src/librustc_typeck/check/writeback.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,6 +561,8 @@ impl<'cx, 'gcx, 'tcx> WritebackCx<'cx, 'gcx, 'tcx> {
if def_id == defin_ty_def_id {
// Concrete type resolved to the existential type itself
// Force a cycle error
// FIXME(oli-obk): we could just not insert it into `concrete_existential_types`
// which simply would make this use not a defining use.
self.tcx().at(span).type_of(defin_ty_def_id);
}
}
Expand Down