Skip to content

Rename and fix nolink-with-link-args test #57233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Rename and fix nolink-with-link-args test
There are three problems with the nolink-with-link-args test:

* The test fails when using MSVC. It's caused by the `linker-flavor=ld` flag which was added in #46291.
* In its comment, this test tests that "link_args are indeed passed when nolink is specified", but the `nolink` attribute has been removed [a long time ago](#12826).
* Pattern has a small typo.

At first I was going to completely remove this test, but there is [a closed pull request for that](#21090).

So:

* rename the file as suggested in the closed PR
* adjust the comment
* fix typo in the pattern
* add `ignore-msvc`.
  • Loading branch information
Smibu committed Dec 31, 2018
commit 794b81ea5eb11db59e1337e3a09b2b2b2480c1bd
12 changes: 12 additions & 0 deletions src/test/compile-fail/invalid-link-args.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
// ignore-msvc due to linker-flavor=ld
// error-pattern:aFdEfSeVEEE
// compile-flags: -C linker-flavor=ld

/* Make sure invalid link_args are printed to stderr. */

#![feature(link_args)]

#[link_args = "aFdEfSeVEEE"]
extern {}

fn main() { }
13 changes: 0 additions & 13 deletions src/test/compile-fail/nolink-with-link-args.rs

This file was deleted.