Skip to content

Rollup of 11 pull requests #56155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Nov 22, 2018
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
bc18857
Return &T / &mut T in ManuallyDrop Deref(Mut) impl
petertodd Oct 29, 2018
b937be8
Clarifying documentation for collections::hash_map::Entry::or_insert
meltinglava Nov 8, 2018
8b750a7
The example values are now easyer to differenciate
meltinglava Nov 13, 2018
a9a48ed
Fix VecDeque pretty-printer
tromey Nov 14, 2018
052bdff
lint based on closure pipe span
csmoe Nov 15, 2018
dbd9abd
update closure arg suggesstion ui test
csmoe Nov 15, 2018
7cb068e
add ui test
lcnr Nov 16, 2018
80c2101
change expected error message
lcnr Nov 16, 2018
218e35e
eat CloseDelim
lcnr Nov 16, 2018
675319e
lint if a private item has doctests
GuillaumeGomez Oct 25, 2018
4c4aff9
remove license
lcnr Nov 16, 2018
646d68f
add a note to the error message
lcnr Nov 16, 2018
fe23ffb
improve error when self is used as not the first argument
lcnr Nov 16, 2018
2be930b
fix tidy (remove whitespace)
lcnr Nov 16, 2018
5bfdcc1
remove stray file with UI testing output
lcnr Nov 17, 2018
d93e5b0
reserve whitespaces between prefix and pipe
csmoe Nov 17, 2018
7c9bcc5
Update any.rs documentation using keyword dyn
0xrgb Nov 19, 2018
a44e446
Add `override_export_symbols` option to Rust target specification
Nov 19, 2018
b8da719
Fix error message for `-C panic=xxx`.
ehuss Nov 19, 2018
88d6094
improve error note
lcnr Nov 20, 2018
8a0909d
Remove incorrect doc comment
bjorn3 Nov 20, 2018
9ce7b11
Remove incorrect doc comment in rustc_mir::monomorphize::item
bjorn3 Nov 20, 2018
9e2e575
Add x86_64-fortanix-unknown-sgx target to the compiler
Nov 19, 2018
e538a4a
core/benches/num: Add `from_str/from_str_radix()` benchmarks
Turbo87 Nov 13, 2018
9aedfd5
Rollup merge of #55367 - GuillaumeGomez:private-item-doc-test-lint, r…
GuillaumeGomez Nov 22, 2018
1c57f0a
Rollup merge of #55485 - petertodd:2018-10-manuallydrop-deref, r=TimNN
GuillaumeGomez Nov 22, 2018
89e0fce
Rollup merge of #55784 - meltinglava:master, r=KodrAus
GuillaumeGomez Nov 22, 2018
fa3941c
Rollup merge of #55961 - tromey:Bug-55944-vecdeque, r=nikomatsakis
GuillaumeGomez Nov 22, 2018
636f0a9
Rollup merge of #55980 - csmoe:issue-55891, r=estebank
GuillaumeGomez Nov 22, 2018
75d226e
Rollup merge of #56002 - Axary:master, r=estebank
GuillaumeGomez Nov 22, 2018
1646fc9
Rollup merge of #56063 - 0xrgb:patch-1, r=joshtriplett
GuillaumeGomez Nov 22, 2018
b473157
Rollup merge of #56067 - jethrogb:jb/sgx-target-spec, r=alexcrichton
GuillaumeGomez Nov 22, 2018
1bc9708
Rollup merge of #56078 - ehuss:fix-panic-opt-msg, r=alexcrichton
GuillaumeGomez Nov 22, 2018
6afecfd
Rollup merge of #56106 - bjorn3:patch-1, r=alexcrichton
GuillaumeGomez Nov 22, 2018
61d7b3e
Rollup merge of #56126 - Turbo87:bench-parse, r=alexcrichton
GuillaumeGomez Nov 22, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
improve error note
  • Loading branch information
lcnr committed Nov 20, 2018
commit 88d60941da317d8e9deee34d2ed5e8dbb54f928c
2 changes: 1 addition & 1 deletion src/libsyntax/parse/parser.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1828,7 +1828,7 @@ impl<'a> Parser<'a> {
let mut err = self.struct_span_err(self.prev_span,
"unexpected `self` argument in function");
err.span_label(self.prev_span,
"`self` is only valid as the first argument of a trait function");
"`self` is only valid as the first argument of an associated function");
return Err(err);
}

Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/invalid-self-argument/bare-fn-start.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
fn a(&self) { }
//~^ ERROR unexpected `self` argument in function
//~| NOTE `self` is only valid as the first argument of a trait function
//~| NOTE `self` is only valid as the first argument of an associated function

fn main() { }
2 changes: 1 addition & 1 deletion src/test/ui/invalid-self-argument/bare-fn-start.stderr
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ error: unexpected `self` argument in function
--> $DIR/bare-fn-start.rs:1:7
|
LL | fn a(&self) { }
| ^^^^ `self` is only valid as the first argument of a trait function
| ^^^^ `self` is only valid as the first argument of an associated function

error: aborting due to previous error

2 changes: 1 addition & 1 deletion src/test/ui/invalid-self-argument/bare-fn.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
fn b(foo: u32, &mut self) { }
//~^ ERROR unexpected `self` argument in function
//~| NOTE `self` is only valid as the first argument of a trait function
//~| NOTE `self` is only valid as the first argument of an associated function

fn main() { }
2 changes: 1 addition & 1 deletion src/test/ui/invalid-self-argument/bare-fn.stderr
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ error: unexpected `self` argument in function
--> $DIR/bare-fn.rs:1:21
|
LL | fn b(foo: u32, &mut self) { }
| ^^^^ `self` is only valid as the first argument of a trait function
| ^^^^ `self` is only valid as the first argument of an associated function

error: aborting due to previous error

2 changes: 1 addition & 1 deletion src/test/ui/invalid-self-argument/trait-fn.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ struct Foo {}
impl Foo {
fn c(foo: u32, self) {}
//~^ ERROR unexpected `self` argument in function
//~| NOTE `self` is only valid as the first argument of a trait function
//~| NOTE `self` is only valid as the first argument of an associated function

fn good(&mut self, foo: u32) {}
}
Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/invalid-self-argument/trait-fn.stderr
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ error: unexpected `self` argument in function
--> $DIR/trait-fn.rs:4:20
|
LL | fn c(foo: u32, self) {}
| ^^^^ `self` is only valid as the first argument of a trait function
| ^^^^ `self` is only valid as the first argument of an associated function

error: aborting due to previous error