Skip to content

avoid shared ref in UnsafeCell::get #56012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2018
Merged

avoid shared ref in UnsafeCell::get #56012

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41434e0
avoid shared ref in UnsafeCell::get
RalfJung Nov 16, 2018
25d46f3
add comment explaining why what we do is legal
RalfJung Nov 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add comment explaining why what we do is legal
  • Loading branch information
@RalfJung
RalfJung committed Nov 17, 2018
commit 25d46f309130be1671d7e44d48e67b23f510bcdc
2 changes: 2 additions & 0 deletions src/libcore/cell.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1509,6 +1509,8 @@ impl<T: ?Sized> UnsafeCell<T> {
#[inline]
#[stable(feature = "rust1", since = "1.0.0")]
pub const fn get(&self) -> *mut T {
// We can just cast the pointer from `UnsafeCell<T>` to `T` because of
// #[repr(transparent)]
self as *const UnsafeCell<T> as *const T as *mut T
}
}
Expand Down