Use token description in "expected/found" parse messages #55455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
estebank
commented
Oct 28, 2018
| @@ -2,7 +2,7 @@ error: expected item, found `;` | |||
| --> $DIR/issue-49040.rs:11:28 | |||
| | | |||
| LL | #![allow(unused_variables)]; //~ ERROR expected item, found `;` | |||
| | ^ help: consider removing this semicolon | |||
There was a problem hiding this comment.
This is a regression, don't approve yet.
| @@ -2,9 +2,7 @@ error: expected item, found `;` | |||
| --> $DIR/issue-46186.rs:13:2 | |||
| | | |||
| LL | }; //~ ERROR expected item, found `;` | |||
| | ^ help: consider removing this semicolon | |||
There was a problem hiding this comment.
Also a regression. Not sure what caused it.
|
📌 Commit 54858d5 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Nov 4, 2018
Use token description in "expected/found" parse messages Fix #54309.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #54309.