Fix trait item doc setting, add new setting, start hiding elements by default and then showing them up #52962
Conversation
… default and then showing them up
rust-highfive
added
the
S-waiting-on-review
| @@ -1674,6 +1674,7 @@ impl<'a> Settings<'a> { | |||
| ("item-attributes", "Auto-hide item attributes.", true), | |||
| ("trait-implementations", "Auto-hide trait implementations documentation", | |||
| true), | |||
| ("method-docs", "Auto-hide item methods' documentation", false), | |||
There was a problem hiding this comment.
Was this setting requested by anyone? It doesn't seem all that necessary to me. "Collapse all" is already saved into local storage.
There was a problem hiding this comment.
We were doing it before through "trait-implementations". Now that I've fixed it, I assume some people might want all their docs collapsed by default so why not providing it?
|
Triage: @QuietMisdreavus Is there any further review needed or can this be merged? |
|
Ping from triage @QuietMisdreavus / @rust-lang/rustdoc: This PR requires your review. |
pietroalbini
added
S-waiting-on-author
|
Ping from triage @GuillaumeGomez: This PR is pending some updates from you. |
|
Seems like the comment was already fixed apparently. |
TimNN
added
S-waiting-on-review
|
Ping from triage, @QuietMisdreavus: This PR is waiting for your review. |
|
@bors r+ |
|
📌 Commit e1ec055 has been approved by |
bors
added
S-waiting-on-bors
Fix trait item doc setting, add new setting, start hiding elements by default and then showing them up r? @QuietMisdreavus
|
☀️ Test successful - status-appveyor, status-travis |
r? @QuietMisdreavus