Skip to content

introduce universes to NLL type check #52488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Jul 26, 2018
Merged
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
a54401e
implement `Step` for `Idx` types
nikomatsakis Jul 22, 2018
145155d
parameterize `BitVector` and `BitMatrix` by their index types
nikomatsakis Jul 22, 2018
40498ba
simplify `NLLRegionVariableOrigin`
nikomatsakis Jul 22, 2018
3f0fb4f
split into two matrices
nikomatsakis Jul 22, 2018
71fef95
SparseBitMatrix: add `ensure_row` helper fn
nikomatsakis Jul 23, 2018
7c74518
SparseBitMatrix: add `insert_all` and `add_all` methods
nikomatsakis Jul 23, 2018
52c94e9
remove inefficiency for adding all points
nikomatsakis Jul 23, 2018
4fce59f
remove unnecessary `blame_span` from `report_region_errors`
nikomatsakis Jul 23, 2018
9ba4d33
rewrite the "constraint graph search" to use a BFS instead of a DFS
nikomatsakis Jul 23, 2018
078220d
extract a `best_blame_constraint` helper
nikomatsakis Jul 23, 2018
92786a4
consolidate and use `find_sub_region_live_at` for everything
nikomatsakis Jul 23, 2018
f277b39
generate extra liveness constraints before regioncx is created
nikomatsakis Jul 23, 2018
2fda456
extract `region_value_str` helper
nikomatsakis Jul 23, 2018
2584216
represent `LivenessValues` with a specialized type
nikomatsakis Jul 23, 2018
b913df0
remove `num_universal_regions` etc from RegionValueElements
nikomatsakis Jul 23, 2018
d9afd2b
introduce new subtyping
nikomatsakis Jul 23, 2018
2acc3e7
add regression test for #48071
nikomatsakis Jul 24, 2018
fa69e21
[3f0fb4f7] improve comment on `to_location`
nikomatsakis Jul 25, 2018
76991ea
[WIP] debug logs in error-reporting
nikomatsakis Jul 25, 2018
0d918a8
improve heuristics for what makes an interesting constraint
nikomatsakis Jul 25, 2018
e43096f
[nit] remove outdated comment
nikomatsakis Jul 25, 2018
d85a7da
Nit: fix Debug impl of `PlaceholderIndex`
nikomatsakis Jul 25, 2018
3171cbe
Nit: improve Binders comment in `relate_tys`
nikomatsakis Jul 25, 2018
21e4a08
Nit: improve comment in hr-fn-aau-eq-abu.rs
nikomatsakis Jul 25, 2018
118cad1
ignore code example in comment
nikomatsakis Jul 25, 2018
9f09127
fix reference file
nikomatsakis Jul 26, 2018
687f252
move mir_check_* to ui tests, add adjusted references
nikomatsakis Jul 26, 2018
fe34c90
patch up mir-opt tests
nikomatsakis Jul 26, 2018
5c603e8
convert tests of `BitVector` to use `BitVector<usize>`
nikomatsakis Jul 26, 2018
d376a6b
add type parameters to `BitMatrix` and `SparseBitMatrix` unit tests
nikomatsakis Jul 26, 2018
ce576ac
fix `sparse_matrix_iter` unit test
nikomatsakis Jul 26, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add type parameters to BitMatrix and SparseBitMatrix unit tests
  • Loading branch information
nikomatsakis committed Jul 26, 2018
commit d376a6bc5d0180758ea2952aed2d374aaa8b093c
6 changes: 3 additions & 3 deletions src/librustc_data_structures/bitvec.rs
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,7 @@ fn grow() {

#[test]
fn matrix_intersection() {
let mut vec1 = BitMatrix::new(200, 200);
let mut vec1: BitMatrix<usize, usize> = BitMatrix::new(200, 200);

// (*) Elements reachable from both 2 and 65.

Expand Down Expand Up @@ -515,7 +515,7 @@ fn matrix_intersection() {

#[test]
fn matrix_iter() {
let mut matrix = BitMatrix::new(64, 100);
let mut matrix: BitMatrix<usize, usize> = BitMatrix::new(64, 100);
matrix.add(3, 22);
matrix.add(3, 75);
matrix.add(2, 99);
Expand Down Expand Up @@ -557,7 +557,7 @@ fn matrix_iter() {

#[test]
fn sparse_matrix_iter() {
let mut matrix = SparseBitMatrix::new(64, 100);
let mut matrix: SparseBitMatrix<usize, usize> = SparseBitMatrix::new(64, 100);
matrix.add(3, 22);
matrix.add(3, 75);
matrix.add(2, 99);
Expand Down