[NLL] Small move error reporting improvements #52359

matthewjasper · 2018-07-13T22:42:27Z

Use a MirBorrowckContext when reporting errors to be more uniform with other error reporting
Add a special message for the case of trying to move from capture variables in Fn and FnMut closures.

part of #51028

rust-highfive · 2018-07-13T22:42:30Z

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

matthewjasper · 2018-07-13T22:42:49Z

r? @pnkfelix

pnkfelix · 2018-07-17T13:18:20Z

@bors r+

bors · 2018-07-17T13:18:21Z

📌 Commit d1acee6ed179b568d62c55bbce960782386188b2 has been approved by pnkfelix

bors · 2018-07-18T05:22:29Z

⌛ Testing commit d1acee6ed179b568d62c55bbce960782386188b2 with merge 94074eada69e5a6390c1e4c8bbe5080e46693a9f...

bors · 2018-07-18T06:03:38Z

💔 Test failed - status-appveyor

kennytm · 2018-07-18T17:06:16Z

---- [ui (nll)] ui\issue-30355.rs stdout ----
diff of stderr:
-	error[E0508]: cannot move out of type `[u8]`, a non-copy slice
-	  --> $DIR/issue-30355.rs:15:8
-	   |
-	LL |     &X(*Y)
-	   |        ^^ cannot move out of here
-	
7	error[E0161]: cannot move a value of type X: the size of X cannot be statically determined
8	  --> $DIR/issue-30355.rs:15:6
9	   |
15	   |
16	LL |     &X(*Y)
17	   |        ^^
+	
+	error[E0508]: cannot move out of type `[u8]`, a non-copy slice
+	  --> $DIR/issue-30355.rs:15:8
+	   |
+	LL |     &X(*Y)
+	   |        ^^ cannot move out of here
18	
19	error: aborting due to 3 previous errors
20

matthewjasper · 2018-07-18T22:58:35Z

Tests updated

kennytm · 2018-07-18T23:04:25Z

@bors r=pnkfelix

bors · 2018-07-18T23:04:26Z

📌 Commit 29bbb1264e2fcf579d363fdff84d8a69d9261c4b has been approved by pnkfelix

euclio · 2018-07-19T17:25:14Z

I realize this PR's already been approved, but if there's still time, it would be worth removing this line (merged in #52197), since this PR fixes the ICE in that test.

matthewjasper · 2018-07-19T20:16:04Z

Done, needs another r+.

bors · 2018-07-21T16:43:29Z

☔ The latest upstream changes (presumably #52405) made this pull request unmergeable. Please resolve the merge conflicts.

Mark-Simulacrum · 2018-07-21T20:41:33Z

@bors r=pnkfelix

bors · 2018-07-21T20:41:33Z

📌 Commit d34924d has been approved by pnkfelix

bors · 2018-07-22T04:58:18Z

⌛ Testing commit d34924d with merge 742e09cdd5516bad425f81372bbcaa9582434ae7...

bors · 2018-07-22T06:52:43Z

💔 Test failed - status-travis

rust-highfive · 2018-07-22T06:52:45Z

The job x86_64-gnu-aux of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

kennytm · 2018-07-22T07:03:51Z

@bors retry travis-ci/travis-ci#9696

[01:51:58] fatal: unable to access 'https://github.com/dzamlo/treeify/': Could not resolve host: github.com

bors · 2018-07-22T08:52:12Z

⌛ Testing commit d34924d with merge aeca042...

…pnkfelix [NLL] Small move error reporting improvements * Use a MirBorrowckContext when reporting errors to be more uniform with other error reporting * Add a special message for the case of trying to move from capture variables in `Fn` and `FnMut` closures. part of #51028

bors · 2018-07-22T10:48:09Z

☀️ Test successful - status-appveyor, status-travis
Approved by: pnkfelix
Pushing aeca042 to master...

rust-highfive assigned eddyb Jul 13, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 13, 2018

rust-highfive assigned pnkfelix and unassigned eddyb Jul 13, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 17, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 18, 2018

kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 18, 2018

matthewjasper force-pushed the combine-move-error-reporting branch from d1acee6 to 29bbb12 Compare July 18, 2018 20:03

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 18, 2018

matthewjasper force-pushed the combine-move-error-reporting branch from 29bbb12 to 8829aee Compare July 19, 2018 20:15

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 21, 2018

matthewjasper added 4 commits July 21, 2018 18:40

Use MirBorrowckCtxt while reporting move errors

341e5e3

Add specific message when moving from upvars in a non-FnOnce closure

1241274

Fix rust-lang#52416 - ice for move errors in unsafe blocks

086c2d0

update tests

d34924d

matthewjasper force-pushed the combine-move-error-reporting branch from 8829aee to d34924d Compare July 21, 2018 17:41

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 21, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 22, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2018

bors merged commit d34924d into rust-lang:master Jul 22, 2018

bors mentioned this pull request Jul 22, 2018

NLL diagnostics replaced nice closure errors w/ indecipherable free region errors #52572

Merged

matthewjasper deleted the combine-move-error-reporting branch September 3, 2018 21:32

pnkfelix mentioned this pull request Oct 9, 2018

error: internal compiler error: Accessing (*_310) with the kind Write(Move) shouldn't be possible #54597

Closed

[NLL] Small move error reporting improvements #52359

[NLL] Small move error reporting improvements #52359

Uh oh!

Conversation

matthewjasper commented Jul 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Jul 13, 2018

Uh oh!

matthewjasper commented Jul 13, 2018

Uh oh!

pnkfelix commented Jul 17, 2018

Uh oh!

bors commented Jul 17, 2018

Uh oh!

bors commented Jul 18, 2018

Uh oh!

bors commented Jul 18, 2018

Uh oh!

kennytm commented Jul 18, 2018

Uh oh!

matthewjasper commented Jul 18, 2018

Uh oh!

kennytm commented Jul 18, 2018

Uh oh!

bors commented Jul 18, 2018

Uh oh!

euclio commented Jul 19, 2018

Uh oh!

matthewjasper commented Jul 19, 2018

Uh oh!

bors commented Jul 21, 2018

Uh oh!

Mark-Simulacrum commented Jul 21, 2018

Uh oh!

bors commented Jul 21, 2018

Uh oh!

bors commented Jul 22, 2018

Uh oh!

bors commented Jul 22, 2018

Uh oh!

rust-highfive commented Jul 22, 2018

Uh oh!

kennytm commented Jul 22, 2018

Uh oh!

bors commented Jul 22, 2018

Uh oh!

bors commented Jul 22, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

matthewjasper commented Jul 13, 2018 •

edited

Loading