Skip to content

expansion/hygiene: Some renaming, refactoring and comments #51726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 24, 2018
Merged

expansion/hygiene: Some renaming, refactoring and comments #51726

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9b2a89b
hygiene: Give `Debug` impls to hygiene structures
petrochenkov Jun 19, 2018
17f20be
expansion: Remove unnecessary override from `impl Folder for Marker`
petrochenkov Jun 19, 2018
b15785b
hygiene: Make sure expansion info is set at most once for a given `Mark`
petrochenkov Jun 19, 2018
869fa27
hygiene: Rename `MarkKind` to `Transparency`
petrochenkov Jun 19, 2018
a127264
expansion: Rename `Expansion` to `AstFragment`
petrochenkov Jun 19, 2018
399da7b
expansion: Improve searchability for `AstFragments` methods
petrochenkov Jun 22, 2018
296955a
expansion: Add some comments
petrochenkov Jun 23, 2018
fffe9fb
hygiene: More descriptive names for things involved in late hygienic …
petrochenkov Jun 23, 2018
c00f5af
hygiene: Do not reset expansion info for `quote!`
petrochenkov Jun 23, 2018
117cb04
hygiene: Make sure transparency of `Mark::root()` is an implementatio…
petrochenkov Jun 23, 2018
20ce910
hygiene: Merge `NameAndSpan` into `ExpnInfo`
petrochenkov Jun 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
expansion: Remove unnecessary override from impl Folder for Marker
  • Loading branch information
@petrochenkov
petrochenkov committed Jun 23, 2018
commit 17f20bec227244a0b47c8c0c24e09452a061e09a
5 changes: 0 additions & 5 deletions src/libsyntax/ext/expand.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1569,11 +1569,6 @@ impl<'feat> ExpansionConfig<'feat> {
pub struct Marker(pub Mark);

impl Folder for Marker {
fn fold_ident(&mut self, mut ident: Ident) -> Ident {
ident.span = ident.span.apply_mark(self.0);
ident
}

fn new_span(&mut self, span: Span) -> Span {
span.apply_mark(self.0)
}
Expand Down