Skip to content

Rollup of 8 pull requests #48158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 26 commits into from
Closed

Rollup of 8 pull requests #48158

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
c04d86d
Work around LLVM OCAML binding installation failure
roblabla Jan 29, 2018
4f8049a
Add Range[Inclusive]::is_empty
scottmcm Feb 9, 2018
7fe182f
Fix tidy
scottmcm Feb 9, 2018
b5cb393
Use is_empty in range iteration exhaustion tests
scottmcm Feb 10, 2018
6f70a11
range_is_empty tracking issue is #48111
scottmcm Feb 10, 2018
0cccd9a
Show better warning for trying to cast non-u8 scalar to char
GuillaumeGomez Feb 6, 2018
14f488e
Whitelist pclmul x86 feature flag
newpavlov Feb 10, 2018
877272b
typo fix
newpavlov Feb 10, 2018
3c01dea
Add comment about the problem, and use provided path if available
roblabla Feb 10, 2018
45d5a42
Correct a few stability attributes
ollie27 Feb 10, 2018
8be3068
added conversion from Rust feature to LLVM feature
newpavlov Feb 10, 2018
c97aa09
iterator instead loop
newpavlov Feb 10, 2018
161e8ff
typo: correct endianess to endianness (this also changes function nam…
matthiaskrgr Feb 10, 2018
7c6adb4
fixed errors
newpavlov Feb 11, 2018
22b0489
Add the emptiness condition to the docs; add a PartialOrd example wit…
scottmcm Feb 11, 2018
bf69b0f
Upgrade the Travis CI macOS images for testing from Xcode 8.3 to 9.2.
kennytm Jan 25, 2018
c2a31de
Dangling pointer fix
newpavlov Feb 11, 2018
bd426f1
Update ops range example to avoid confusion between indexes and values.
Feb 12, 2018
ee1ce9d
Rollup merge of #47846 - roblabla:bugfix-ocaml, r=kennytm
kennytm Feb 12, 2018
c268e6f
Rollup merge of #48033 - GuillaumeGomez:better-char-cast-message, r=e…
kennytm Feb 12, 2018
f50183d
Rollup merge of #48087 - scottmcm:range_is_empty, r=kennytm,alexcrich…
kennytm Feb 12, 2018
5a0a9a0
Rollup merge of #48114 - kennytm:xcode9, r=alexcrichton Upgrade the T…
kennytm Feb 12, 2018
3d1ed35
Rollup merge of #48126 - newpavlov:patch-1, r=alexcrichton Whitelist …
kennytm Feb 12, 2018
2c1accb
Rollup merge of #48130 - ollie27:stab, r=Mark-Simulacrum Correct a fe…
kennytm Feb 12, 2018
2fa76cd
Rollup merge of #48133 - matthiaskrgr:endianess_to_endianness, r=oli-…
kennytm Feb 12, 2018
b4b49eb
Rollup merge of #48151 - echochamber:update_range_example, r=estebank…
kennytm Feb 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
range_is_empty tracking issue is #48111
  • Loading branch information
@scottmcm
scottmcm committed Feb 10, 2018
commit 6f70a11a831992fe86a935a0d649d3aa6b16dc50
4 changes: 2 additions & 2 deletions src/libcore/ops/range.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ impl<Idx: PartialOrd<Idx>> Range<Idx> {
/// assert!( (3..3).is_empty());
/// assert!( (3..2).is_empty());
/// ```
#[unstable(feature = "range_is_empty", reason = "recently added", issue = "123456789")]
#[unstable(feature = "range_is_empty", reason = "recently added", issue = "48111")]
pub fn is_empty(&self) -> bool {
!(self.start < self.end)
}
Expand Down Expand Up @@ -347,7 +347,7 @@ impl<Idx: PartialOrd<Idx>> RangeInclusive<Idx> {
/// // Precise field values are unspecified here
/// assert!(r.is_empty());
/// ```
#[unstable(feature = "range_is_empty", reason = "recently added", issue = "123456789")]
#[unstable(feature = "range_is_empty", reason = "recently added", issue = "48111")]
pub fn is_empty(&self) -> bool {
!(self.start <= self.end)
}
Expand Down