Fix invalid HTML escape #46326
Fix invalid HTML escape #46326
Conversation
src/librustdoc/html/render.rs
Outdated
| name_len, | ||
| indent: 0, | ||
| })?; | ||
| if w.alternate() { |
There was a problem hiding this comment.
What is this change for? item_function is only used to produce HTML.
There was a problem hiding this comment.
Because in the slidebar on the left, we call these function and escape the text once again. Guess what happens when you escape a string twice?
There was a problem hiding this comment.
This function isn't used for rendering the sidebar. This piece of code is rendering the <pre> block at the top of function pages.
There was a problem hiding this comment.
Yes but does it hurt to have this? Seems logical that the alternate handling is propagated to the children no? But if it's an issue, I'll just remove it.
There was a problem hiding this comment.
alternate is never set so this is an issue because it's dead code.
There was a problem hiding this comment.
Ok, I'll just remove the update in here then.
src/librustdoc/html/render.rs
Outdated
| indent, | ||
| end_newline, | ||
| }) | ||
| if w.alternate() { |
There was a problem hiding this comment.
This change still needs to be removed.
GuillaumeGomez
force-pushed
the
sidebar-text
branch
from
3b294f9 to
c1746ce
Compare
kennytm
added
the
S-waiting-on-review
GuillaumeGomez
force-pushed
the
sidebar-text
branch
from
c1746ce to
daec497
Compare
|
@ollie27: You were absolutely right, the first change was completely useless. It even allowed me to see that the url encoding was incomplete. Thanks for that too! :) |
GuillaumeGomez
force-pushed
the
sidebar-text
branch
from
daec497 to
35f5be6
Compare
|
@bors r+ |
|
📌 Commit 35f5be6 has been approved by |
Fix invalid HTML escape Fixes #46289. r? @QuietMisdreavus
|
☀️ Test successful - status-appveyor, status-travis |
Fixes #46289.
r? @QuietMisdreavus