-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Add a MIR pass to lower 128-bit operators to lang item calls #46093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,240 @@ | ||
// Copyright 2017 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
//! Replaces 128-bit operators with lang item calls | ||
|
||
use rustc::hir::def_id::DefId; | ||
use rustc::middle::lang_items::LangItem; | ||
use rustc::mir::*; | ||
use rustc::ty::{Slice, Ty, TyCtxt, TypeVariants}; | ||
use rustc_data_structures::indexed_vec::{Idx}; | ||
use transform::{MirPass, MirSource}; | ||
use syntax; | ||
|
||
pub struct Lower128Bit; | ||
|
||
impl MirPass for Lower128Bit { | ||
fn run_pass<'a, 'tcx>(&self, | ||
tcx: TyCtxt<'a, 'tcx, 'tcx>, | ||
_src: MirSource, | ||
mir: &mut Mir<'tcx>) { | ||
if !tcx.sess.opts.debugging_opts.lower_128bit_ops { | ||
return | ||
} | ||
|
||
self.lower_128bit_ops(tcx, mir); | ||
} | ||
} | ||
|
||
impl Lower128Bit { | ||
fn lower_128bit_ops<'a, 'tcx>(&self, tcx: TyCtxt<'a, 'tcx, 'tcx>, mir: &mut Mir<'tcx>) { | ||
let mut new_blocks = Vec::new(); | ||
let cur_len = mir.basic_blocks().len(); | ||
|
||
let (basic_blocks, local_decls) = mir.basic_blocks_and_local_decls_mut(); | ||
for block in basic_blocks.iter_mut() { | ||
for i in (0..block.statements.len()).rev() { | ||
let (lang_item, rhs_kind) = | ||
if let Some((lang_item, rhs_kind)) = | ||
lower_to(&block.statements[i], local_decls, tcx) | ||
{ | ||
(lang_item, rhs_kind) | ||
} else { | ||
continue; | ||
}; | ||
|
||
let rhs_override_ty = rhs_kind.ty(tcx); | ||
let cast_local = | ||
match rhs_override_ty { | ||
None => None, | ||
Some(ty) => { | ||
let local_decl = LocalDecl::new_internal( | ||
ty, block.statements[i].source_info.span); | ||
Some(local_decls.push(local_decl)) | ||
}, | ||
}; | ||
|
||
let storage_dead = cast_local.map(|local| { | ||
Statement { | ||
source_info: block.statements[i].source_info, | ||
kind: StatementKind::StorageDead(local), | ||
} | ||
}); | ||
let after_call = BasicBlockData { | ||
statements: storage_dead.into_iter() | ||
.chain(block.statements.drain((i+1)..)).collect(), | ||
is_cleanup: block.is_cleanup, | ||
terminator: block.terminator.take(), | ||
}; | ||
|
||
let bin_statement = block.statements.pop().unwrap(); | ||
let (source_info, lvalue, lhs, mut rhs) = match bin_statement { | ||
Statement { | ||
source_info, | ||
kind: StatementKind::Assign( | ||
lvalue, | ||
Rvalue::BinaryOp(_, lhs, rhs)) | ||
} => (source_info, lvalue, lhs, rhs), | ||
Statement { | ||
source_info, | ||
kind: StatementKind::Assign( | ||
lvalue, | ||
Rvalue::CheckedBinaryOp(_, lhs, rhs)) | ||
} => (source_info, lvalue, lhs, rhs), | ||
_ => bug!("Statement doesn't match pattern any more?"), | ||
}; | ||
|
||
if let Some(local) = cast_local { | ||
block.statements.push(Statement { | ||
source_info: source_info, | ||
kind: StatementKind::StorageLive(local), | ||
}); | ||
block.statements.push(Statement { | ||
source_info: source_info, | ||
kind: StatementKind::Assign( | ||
Lvalue::Local(local), | ||
Rvalue::Cast( | ||
CastKind::Misc, | ||
rhs, | ||
rhs_override_ty.unwrap())), | ||
}); | ||
rhs = Operand::Consume(Lvalue::Local(local)); | ||
} | ||
|
||
let call_did = check_lang_item_type( | ||
lang_item, &lvalue, &lhs, &rhs, local_decls, tcx); | ||
|
||
let bb = BasicBlock::new(cur_len + new_blocks.len()); | ||
new_blocks.push(after_call); | ||
|
||
block.terminator = | ||
Some(Terminator { | ||
source_info, | ||
kind: TerminatorKind::Call { | ||
func: Operand::function_handle(tcx, call_did, | ||
Slice::empty(), source_info.span), | ||
args: vec![lhs, rhs], | ||
destination: Some((lvalue, bb)), | ||
cleanup: None, | ||
}, | ||
}); | ||
} | ||
} | ||
|
||
basic_blocks.extend(new_blocks); | ||
} | ||
} | ||
|
||
fn check_lang_item_type<'a, 'tcx, D>( | ||
lang_item: LangItem, | ||
lvalue: &Lvalue<'tcx>, | ||
lhs: &Operand<'tcx>, | ||
rhs: &Operand<'tcx>, | ||
local_decls: &D, | ||
tcx: TyCtxt<'a, 'tcx, 'tcx>) | ||
-> DefId | ||
where D: HasLocalDecls<'tcx> | ||
{ | ||
let did = tcx.require_lang_item(lang_item); | ||
let poly_sig = tcx.fn_sig(did); | ||
let sig = tcx.no_late_bound_regions(&poly_sig).unwrap(); | ||
let lhs_ty = lhs.ty(local_decls, tcx); | ||
let rhs_ty = rhs.ty(local_decls, tcx); | ||
let lvalue_ty = lvalue.ty(local_decls, tcx).to_ty(tcx); | ||
let expected = [lhs_ty, rhs_ty, lvalue_ty]; | ||
assert_eq!(sig.inputs_and_output[..], expected, | ||
"lang item {}", tcx.def_symbol_name(did)); | ||
did | ||
} | ||
|
||
fn lower_to<'a, 'tcx, D>(statement: &Statement<'tcx>, local_decls: &D, tcx: TyCtxt<'a, 'tcx, 'tcx>) | ||
-> Option<(LangItem, RhsKind)> | ||
where D: HasLocalDecls<'tcx> | ||
{ | ||
match statement.kind { | ||
StatementKind::Assign(_, Rvalue::BinaryOp(bin_op, ref lhs, _)) => { | ||
let ty = lhs.ty(local_decls, tcx); | ||
if let Some(is_signed) = sign_of_128bit(ty) { | ||
return item_for_op(bin_op, is_signed); | ||
} | ||
}, | ||
StatementKind::Assign(_, Rvalue::CheckedBinaryOp(bin_op, ref lhs, _)) => { | ||
let ty = lhs.ty(local_decls, tcx); | ||
if let Some(is_signed) = sign_of_128bit(ty) { | ||
return item_for_checked_op(bin_op, is_signed); | ||
} | ||
}, | ||
_ => {}, | ||
} | ||
None | ||
} | ||
|
||
#[derive(Copy, Clone)] | ||
enum RhsKind { | ||
Unchanged, | ||
ForceU128, | ||
ForceU32, | ||
} | ||
|
||
impl RhsKind { | ||
fn ty<'a, 'tcx>(&self, tcx: TyCtxt<'a, 'tcx, 'tcx>) -> Option<Ty<'tcx>> { | ||
match *self { | ||
RhsKind::Unchanged => None, | ||
RhsKind::ForceU128 => Some(tcx.types.u128), | ||
RhsKind::ForceU32 => Some(tcx.types.u32), | ||
} | ||
} | ||
} | ||
|
||
fn sign_of_128bit(ty: Ty) -> Option<bool> { | ||
match ty.sty { | ||
TypeVariants::TyInt(syntax::ast::IntTy::I128) => Some(true), | ||
TypeVariants::TyUint(syntax::ast::UintTy::U128) => Some(false), | ||
_ => None, | ||
} | ||
} | ||
|
||
fn item_for_op(bin_op: BinOp, is_signed: bool) -> Option<(LangItem, RhsKind)> { | ||
let i = match (bin_op, is_signed) { | ||
(BinOp::Add, true) => (LangItem::I128AddFnLangItem, RhsKind::Unchanged), | ||
(BinOp::Add, false) => (LangItem::U128AddFnLangItem, RhsKind::Unchanged), | ||
(BinOp::Sub, true) => (LangItem::I128SubFnLangItem, RhsKind::Unchanged), | ||
(BinOp::Sub, false) => (LangItem::U128SubFnLangItem, RhsKind::Unchanged), | ||
(BinOp::Mul, true) => (LangItem::I128MulFnLangItem, RhsKind::Unchanged), | ||
(BinOp::Mul, false) => (LangItem::U128MulFnLangItem, RhsKind::Unchanged), | ||
(BinOp::Div, true) => (LangItem::I128DivFnLangItem, RhsKind::Unchanged), | ||
(BinOp::Div, false) => (LangItem::U128DivFnLangItem, RhsKind::Unchanged), | ||
(BinOp::Rem, true) => (LangItem::I128RemFnLangItem, RhsKind::Unchanged), | ||
(BinOp::Rem, false) => (LangItem::U128RemFnLangItem, RhsKind::Unchanged), | ||
(BinOp::Shl, true) => (LangItem::I128ShlFnLangItem, RhsKind::ForceU32), | ||
(BinOp::Shl, false) => (LangItem::U128ShlFnLangItem, RhsKind::ForceU32), | ||
(BinOp::Shr, true) => (LangItem::I128ShrFnLangItem, RhsKind::ForceU32), | ||
(BinOp::Shr, false) => (LangItem::U128ShrFnLangItem, RhsKind::ForceU32), | ||
_ => return None, | ||
}; | ||
Some(i) | ||
} | ||
|
||
fn item_for_checked_op(bin_op: BinOp, is_signed: bool) -> Option<(LangItem, RhsKind)> { | ||
let i = match (bin_op, is_signed) { | ||
(BinOp::Add, true) => (LangItem::I128AddoFnLangItem, RhsKind::Unchanged), | ||
(BinOp::Add, false) => (LangItem::U128AddoFnLangItem, RhsKind::Unchanged), | ||
(BinOp::Sub, true) => (LangItem::I128SuboFnLangItem, RhsKind::Unchanged), | ||
(BinOp::Sub, false) => (LangItem::U128SuboFnLangItem, RhsKind::Unchanged), | ||
(BinOp::Mul, true) => (LangItem::I128MuloFnLangItem, RhsKind::Unchanged), | ||
(BinOp::Mul, false) => (LangItem::U128MuloFnLangItem, RhsKind::Unchanged), | ||
(BinOp::Shl, true) => (LangItem::I128ShloFnLangItem, RhsKind::ForceU128), | ||
(BinOp::Shl, false) => (LangItem::U128ShloFnLangItem, RhsKind::ForceU128), | ||
(BinOp::Shr, true) => (LangItem::I128ShroFnLangItem, RhsKind::ForceU128), | ||
(BinOp::Shr, false) => (LangItem::U128ShroFnLangItem, RhsKind::ForceU128), | ||
_ => bug!("That should be all the checked ones?"), | ||
}; | ||
Some(i) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why specifically u128 for overflowing shifts? Is there an already-existing implementation that takes u128 as a shift count (I couldn’t find it in compiler-builtins)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's unfortunately necessary to preserve the current behaviour of
https://play.rust-lang.org/?gist=78f8381aac3ef89febcb48e56194e948&version=nightly
Any smaller type and the fact the shift is out of range would be lost.