Fix a bug where the rustfmt tarball was not being produced #46025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This makes complete sense to me now -- neither RLS nor Rustfmt are marked as default steps in rustbuild, so neither will run unless their paths are specified or they are required by a different build step (e.g., extended). @bors r+ p=1 |
|
📌 Commit 262029e has been approved by |
bors
added a commit
that referenced
this pull request
Nov 16, 2017
Fix a bug where the rustfmt tarball was not being produced r? @alexcrichton This makes rustfmt a dep of 'extended', which seems to be necessary for the rustfmt dist step to actually get run.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @alexcrichton
This makes rustfmt a dep of 'extended', which seems to be necessary for the rustfmt dist step to actually get run.