impl From<T> for AtomicT #45610
Merged
impl From<T> for AtomicT #45610
+12
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
added
S-waiting-on-review
strake
force-pushed
the
atomic_from
branch
2 times, most recently
from
17b9cc1
to
5c21637
Compare
nagisa
reviewed
Oct 29, 2017
src/libcore/sync/atomic.rs
Outdated
| @@ -927,6 +927,12 @@ impl<T> AtomicPtr<T> { | |||
| } | |||
| } | |||
|
|
|||
| #[stable(feature = "rust1", since = "1.0.0")] | |||
There was a problem hiding this comment.
This is wrong as it implies the implementation has existed since 1.0.0. You need to make a new stable feature.
There was a problem hiding this comment.
Ahh, that makes sense now — it complained about (feature = "rust1", since = "1.22.0").
nagisa
reviewed
Oct 29, 2017
src/libcore/sync/atomic.rs
Outdated
| @@ -967,6 +973,12 @@ macro_rules! atomic_int { | |||
| } | |||
| } | |||
|
|
|||
| #[$stable] | |||
|
@bors r+ |
|
📌 Commit 80a3191 has been approved by |
|
@bors r- 1.22.0 is current beta release, so this feature would release with 1.23 at the earliest. The version number should be changed to 1.23. |
kennytm
added
S-waiting-on-author
|
@bors r=nagisa |
|
📌 Commit be21779 has been approved by |
kennytm
added
relnotes
|
@bors rollup |
|
⌛ Testing commit be21779 with merge 0fb1b7cf5a4d6903348b8bd137a44419f9555cb3... |
|
💔 Test failed - status-travis |
|
@bors retry |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Nov 4, 2017
impl From<T> for AtomicT
bors
added a commit
that referenced
this pull request
Nov 4, 2017
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Nov 29, 2017
impl From<bool> for AtomicBool This seems like an obvious omission from rust-lang#45610. ~~I've used the same feature name and version in the hope that this can be backported to beta so it's stabilized with the other impls. If it can't be I'll change it to `1.24.0`.~~
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Jan 4, 2018
Correct a few stability attributes * The extra impls for `ManuallyDrop` were added in rust-lang#44310 which was only stabilised in 1.22.0. * The impls for `SliceIndex` were stabilised in rust-lang#43373 but as `RangeInclusive` and `RangeToInclusive` are still unstable the impls should remain unstable. * The `From` impls for atomic integers were added in rust-lang#45610 but most atomic integers are still unstable. * The `shared_from_slice2` impls were added in rust-lang#45990 but they won't be stable until 1.24.0. * The `Mutex` and `RwLock` impls were added in rust-lang#46082 but won't be stable until 1.24.0.
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Jan 4, 2018
Correct a few stability attributes * The extra impls for `ManuallyDrop` were added in rust-lang#44310 which was only stabilised in 1.22.0. * The impls for `SliceIndex` were stabilised in rust-lang#43373 but as `RangeInclusive` and `RangeToInclusive` are still unstable the impls should remain unstable. * The `From` impls for atomic integers were added in rust-lang#45610 but most atomic integers are still unstable. * The `shared_from_slice2` impls were added in rust-lang#45990 but they won't be stable until 1.24.0. * The `Mutex` and `RwLock` impls were added in rust-lang#46082 but won't be stable until 1.24.0.
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Jan 5, 2018
Correct a few stability attributes * The extra impls for `ManuallyDrop` were added in rust-lang#44310 which was only stabilised in 1.22.0. * The impls for `SliceIndex` were stabilised in rust-lang#43373 but as `RangeInclusive` and `RangeToInclusive` are still unstable the impls should remain unstable. * The `From` impls for atomic integers were added in rust-lang#45610 but most atomic integers are still unstable. * The `shared_from_slice2` impls were added in rust-lang#45990 but they won't be stable until 1.24.0. * The `Mutex` and `RwLock` impls were added in rust-lang#46082 but won't be stable until 1.24.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.