Skip to content

incr.comp.: Switch to red/green change tracking, remove legacy system. #44901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 4, 2017
Merged

incr.comp.: Switch to red/green change tracking, remove legacy system. #44901

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a948be8
incr.comp.: Determine red/green state of every new node.
michaelwoerister Sep 25, 2017
6db27d9
incr.comp.: Add minimal version of try_mark_green procedure.
michaelwoerister Sep 25, 2017
f0bbf4e
incr.comp.: Re-execute queries during red/green marking in order to f…
michaelwoerister Sep 26, 2017
e1994bd
incr.comp.: Make some DepNodes non-anonymous.
michaelwoerister Sep 27, 2017
c9a17ef
incr.comp.: Add some logging to DepGraph::try_mark_green().
michaelwoerister Sep 27, 2017
e6badfd
incr.comp.: Use red/green tracking for CGU re-use.
michaelwoerister Sep 28, 2017
272c324
incr.comp.: Build DepGraphQuery from new dep-graph impl.
michaelwoerister Sep 28, 2017
171c020
incr.comp.: Remove saving and loading of legacy dep-graph.
michaelwoerister Sep 28, 2017
df06a7e
incr.comp.: Remove legacy dep-graph runtime.
michaelwoerister Sep 28, 2017
dbab705
incr.comp.: Do some cleanup.
michaelwoerister Sep 28, 2017
c96d0bf
incr.comp.: Fix some merge fallout.
michaelwoerister Sep 29, 2017
0454a41
incr.comp.: Address review comments.
michaelwoerister Oct 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
incr.comp.: Do some cleanup.
  • Loading branch information
@michaelwoerister
michaelwoerister committed Oct 2, 2017
commit dbab705f04037f0eeb35f10b994214c992597ed4
5 changes: 4 additions & 1 deletion src/librustc/dep_graph/graph.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,7 +501,10 @@ impl DepGraph {
debug!("try_mark_green({:?}) --- trying to force \
dependency {:?}", dep_node, dep_dep_node);
if ::ty::maps::force_from_dep_node(tcx, dep_dep_node) {
let dep_dep_node_color = data.colors.borrow().get(dep_dep_node).cloned();
let dep_dep_node_color = data.colors
.borrow()
.get(dep_dep_node)
.cloned();
match dep_dep_node_color {
Some(DepNodeColor::Green(node_index)) => {
debug!("try_mark_green({:?}) --- managed to \
Expand Down
2 changes: 0 additions & 2 deletions src/librustc_trans/back/symbol_export.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,6 @@ pub fn provide_local(providers: &mut Providers) {
};

providers.is_exported_symbol = |tcx, id| {
// FIXME(#42293) needs red/green to not break a bunch of incremental
// tests
tcx.exported_symbol_ids(id.krate).contains(&id)
};

Expand Down