Skip to content

Conversation

@spastorino
Copy link
Member

These are the rest of the repeated implementations for new and index methods. Follow up of #44889

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 27, 2017

📌 Commit e0e14c9 has been approved by nikomatsakis

@aidanhs aidanhs added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 28, 2017
@bors
Copy link
Collaborator

bors commented Sep 30, 2017

⌛ Testing commit e0e14c9 with merge 4491ea5...

bors added a commit that referenced this pull request Sep 30, 2017
Remove new and index methods already implement for Idx

These are the rest of the repeated implementations for new and index methods. Follow up of #44889
@bors
Copy link
Collaborator

bors commented Sep 30, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 4491ea5 to master...

@spastorino
Copy link
Member Author

This is already merged.

@spastorino spastorino closed this Sep 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants