Skip to content

Infer T: 'x outlives requirements on structs #44493#44708

Closed
toidiu wants to merge 1 commit intorust-lang:masterfrom
toidiu:ak-44493
Closed

Infer T: 'x outlives requirements on structs #44493#44708
toidiu wants to merge 1 commit intorust-lang:masterfrom
toidiu:ak-44493

Conversation

@toidiu
Copy link
Contributor

@toidiu toidiu commented Sep 19, 2017

@rust-highfive
Copy link
Contributor

rust-highfive commented Sep 19, 2017

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @arielb1 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@arielb1
Copy link
Contributor

arielb1 commented Sep 20, 2017 •
edited
Loading

Can you fix your rebase? Your commits are quite messy.

@arielb1 arielb1 added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 20, 2017
@nikomatsakis
Copy link
Contributor

nikomatsakis commented Sep 25, 2017

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 25, 2017

📌 Commit 15fa85c has been approved by nikomatsakis

@arielb1 arielb1 added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 26, 2017
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Sep 29, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#44708 - toidiu:ak-44493, r=nikomatsakis
8083877 
Infer `T: 'x` outlives requirements on structs rust-lang#44493

rust-lang#44493
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Sep 29, 2017
Closed
bors added a commit that referenced this pull request Sep 30, 2017
@bors
Auto merge of #44936 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
c4cca3a 
Rollup of 15 pull requests

- Successful merges: #44124, #44287, #44320, #44694, #44708, #44794, #44797, #44824, #44836, #44840, #44845, #44854, #44889, #44900, #44903
- Failed merges:
@bors
Copy link
Collaborator

bors commented Sep 30, 2017

☔ The latest upstream changes (presumably #44936) made this pull request unmergeable. Please resolve the merge conflicts.

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Sep 30, 2017

Merged in #44936.

@toidiu toidiu deleted the ak-44493 branch March 22, 2018 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@arielb1 arielb1

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@toidiu @rust-highfive @arielb1 @nikomatsakis @bors @Mark-Simulacrum