rustbuild improvements #41577
rustbuild improvements #41577
Conversation
Build them directly in the `./x.py build` phase, don't wait for `./x.py dist` Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
This way its files take precedence (e.g. README.md and stuff) Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
|
@bors: r+ Looks good to me, thanks! |
|
📌 Commit 7b1fb89 has been approved by |
|
Should I submit that to the beta branch too? |
|
We typically try to be conservative with backports (limited to bug fixes) as opposed to new features, but if you'd like a backport if you wouldn't mind expanding on the rationale I can tag this for discussion with the appropriate team. |
|
Well, I use these for packaging rust downstream for Exherbo, but I'm fine with doing the backport downstream for a couple of months |
|
Ok if that's ok with you I'll avoid the backport tag for now, but if that doesn't work we can still consider backporting! |
rustbuild improvements Properly hook up cargo and rls in the build phase, and install them, when extended build is enabled.
alexcrichton
added
the
S-waiting-on-bors
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
|
I guess it makes sense to only build cargo for the host, like we do for rls. This should fix the failure. |
|
@bors: r+ |
|
📌 Commit a8c6ba9 has been approved by |
rustbuild improvements Properly hook up cargo and rls in the build phase, and install them, when extended build is enabled.
|
☀️ Test successful - status-appveyor, status-travis |
4 participants
Properly hook up cargo and rls in the build phase, and install them, when extended build is enabled.