Skip to content

Conversation

@alexcrichton
Copy link
Member

This gives us the benefit of supporting file descriptors over the limit that
select supports, which...

Closes #40894

@rust-highfive
Copy link
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@nagisa
Copy link
Member

nagisa commented Apr 3, 2017

r=me

@nagisa
Copy link
Member

nagisa commented Apr 3, 2017

I think you might need libc::POLLERR and libc::POLLHUP as well?

@alexcrichton
Copy link
Member Author

According to the poll man page:

The bits returned in revents can
include any of those specified in events, or one of the values
POLLERR, POLLHUP, or POLLNVAL. (These three bits are meaningless in
the events field, and will be set in the revents field whenever the
corresponding condition is true.)

So in that sense I don't think we need to ask for them explicitly? I originally had them in but removed them due to that clause.

@bors r=nagisa

@bors
Copy link
Collaborator

bors commented Apr 3, 2017

📌 Commit 47c6187 has been approved by nagisa

@alexcrichton
Copy link
Member Author

@bors: r=nagisa

@bors
Copy link
Collaborator

bors commented Apr 4, 2017

📌 Commit 47e8f3b has been approved by nagisa

This gives us the benefit of supporting file descriptors over the limit that
select supports, which...

Closes rust-lang#40894
@alexcrichton
Copy link
Member Author

@bors: r=nagisa

@bors
Copy link
Collaborator

bors commented Apr 4, 2017

📌 Commit 8c01ce3 has been approved by nagisa

@bors
Copy link
Collaborator

bors commented Apr 6, 2017

⌛ Testing commit 8c01ce3 with merge 44855a4...

bors added a commit that referenced this pull request Apr 6, 2017
std: Use `poll` instead of `select`

This gives us the benefit of supporting file descriptors over the limit that
select supports, which...

Closes #40894
@bors
Copy link
Collaborator

bors commented Apr 6, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: nagisa
Pushing 44855a4 to master...

@bors bors merged commit 8c01ce3 into rust-lang:master Apr 6, 2017
@alexcrichton alexcrichton deleted the process-poll branch April 19, 2017 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants