[beta] next #40046
Merged
[beta] next #40046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are some samples that I have been focusing on improving over time. In this PR, I mainly want to stem the bleeding where we in some cases we show an error that gives you no possible way to divine the problem.
According to the LLVM reference: > A value of 0 or an omitted align argument means that the operation has the ABI alignment for the target. So loads/stores of fields of packed structs need to have their align set to 1. Implement that by tracking the alignment of `LvalueRef`s. Fixes rust-lang#39376.
The function was a footgun because it created `undef` references to ZSTs, which could cause trouble were they to leak to user code.
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
|
|
|
@bors: r+ |
|
📌 Commit e7235d3 has been approved by |
|
@bors: p=1 (beta branch_ |
|
⌛ Testing commit e7235d3 with merge a925124... |
|
💔 Test failed - status-travis |
|
@bors: retry
* network error
…On Thu, Feb 23, 2017 at 12:12 AM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/204479279>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#40046 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95OmHMXGD9RwNLVriGZMfWPN8MgVdks5rfSM4gaJpZM4MJe-_>
.
|
|
@brson diff looks ok to me re: that commit |
|
⌛ Testing commit e7235d3 with merge da59c36... |
|
💔 Test failed - status-travis |
|
@bors: retry
* android bot ran out of disk space?
…On Thu, Feb 23, 2017 at 8:02 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/204801768>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#40046 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95AYDZg6rOFMpmK1GLyj5PDS-QFvlks5rfjoegaJpZM4MJe-_>
.
|
|
@bors: retry
* network failure
…On Sat, Feb 25, 2017 at 10:34 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/205433364>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#40046 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95EORdBZojqe5wc8RgCqV3XWEKnBMks5rgQDCgaJpZM4MJe-_>
.
|
|
⌛ Testing commit 625f598 with merge 6a56824... |
|
💔 Test failed - status-travis |
|
|
Attempting to handle in #40135 |
PRs can't land againt beta right now because the android bot is filling up on disk space. I don't really know what's going on but the android bot is the longest one to run anyway so it'll benefit from being split up regardless.
|
@bors: r+ |
|
📌 Commit f0477b2 has been approved by |
|
⌛ Testing commit f0477b2 with merge 5fee06b... |
|
@bors: retry |
|
💔 Test failed - status-travis |
|
⌛ Testing commit f0477b2 with merge 8c56af1... |
|
💔 Test failed - status-appveyor |
|
@bors: retry
* network error
…On Tue, Feb 28, 2017 at 1:19 PM, bors ***@***.***> wrote:
💔 Test failed - status-appveyor
<https://ci.appveyor.com/project/rust-lang/rust/build/1.0.2161>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#40046 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95KeJjiM5B_s7IXOWT5oxSycvbc3nks5rhHNSgaJpZM4MJe-_>
.
|
|
⌛ Testing commit f0477b2 with merge 68f8347... |
|
💔 Test failed - status-travis |
|
@bors: retry
|
|
⌛ Testing commit f0477b2 with merge 9c10139... |
|
💔 Test failed - status-travis |
|
My guess is that it's yet another spurious failure, but I can't read the logs, so I'll wait to find out. |
|
… On Wed, Mar 1, 2017 at 4:16 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/206744191>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#40046 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95JPDsTW40WdH5vC9xSMsB9HXtF9Oks5rhe4qgaJpZM4MJe-_>
.
|
|
⌛ Testing commit f0477b2 with merge ecbf0b5... |
bors
added a commit
that referenced
this pull request
Mar 2, 2017
[beta] next - #39913 - #39730 - #39674 - #39602 - #39586 - #39471 - #39980 - #40020 - #40135 @nikomatsakis [this commit](3787d33) did not pick cleanly. You might peek at it. I took the liberty of accepting all the nominations myself, but the [packed struct alignment](#39586) PR is quite large. It did pick fine though and there's a comment there suggesting it works on beta cc @rust-lang/compiler. cc @alexcrichton
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nikomatsakis this commit did not pick cleanly. You might peek at it.
I took the liberty of accepting all the nominations myself, but the packed struct alignment PR is quite large. It did pick fine though and there's a comment there suggesting it works on beta cc @rust-lang/compiler.
cc @alexcrichton