Skip to content

In std:rc, clarify the lack of mutability inside an Rc #39299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2017
Merged

In std:rc, clarify the lack of mutability inside an Rc #39299

merged 1 commit into from
Feb 3, 2017

Conversation

@federicomenaquintero
Copy link
Contributor

@federicomenaquintero federicomenaquintero commented Jan 25, 2017

Also, point to the example in Cell's docs for how to do it.

@rust-highfive
Copy link
Contributor

rust-highfive commented Jan 25, 2017

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @BurntSushi (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

GuillaumeGomez
GuillaumeGomez requested changes Jan 31, 2017
View reviewed changes
Copy link
Member

@GuillaumeGomez GuillaumeGomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits.

src/liballoc/rc.rs Outdated
Copy link
Member

@GuillaumeGomez GuillaumeGomez Jan 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra whitespace before "if you need mutability".

src/liballoc/rc.rs Outdated
Copy link
Member

@GuillaumeGomez GuillaumeGomez Jan 31, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

`Rc` should be [`Rc`].

src/liballoc/rc.rs Outdated
Copy link
Member

@GuillaumeGomez GuillaumeGomez Jan 31, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

`Rc` should be [`Rc`].

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Jan 31, 2017

Just a few nits and it'll be good!

@federicomenaquintero
Copy link
Contributor Author

federicomenaquintero commented Jan 31, 2017

Pushed an extra commit to de-nitify.

GuillaumeGomez
GuillaumeGomez reviewed Jan 31, 2017
View reviewed changes
src/liballoc/rc.rs Outdated
Copy link
Member

@GuillaumeGomez GuillaumeGomez Jan 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is longer than 100 characters so tidy fails.

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Jan 31, 2017

Once your tidy issue has been fixed, please squash your commits.

@federicomenaquintero
In std:rc, clarify the lack of mutability inside an Rc
4a07e72 
Also, point to the example in Cell's docs for how to do it.
@federicomenaquintero
Copy link
Contributor Author

federicomenaquintero commented Feb 1, 2017

I've pushed a squashed version. This also has a shortened link name so the line in the references doesn't exceed 100 chars :-P

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Feb 1, 2017

Thanks!

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Feb 1, 2017

📌 Commit 4a07e72 has been approved by GuillaumeGomez

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 2, 2017
@GuillaumeGomez
Rollup merge of rust-lang#39299 - federicomenaquintero:master, r=Guil…
b03436d 
…laumeGomez

In std:rc, clarify the lack of mutability inside an Rc

Also, point to the example in Cell's docs for how to do it.
@GuillaumeGomez GuillaumeGomez mentioned this pull request Feb 2, 2017
Merged
bors added a commit that referenced this pull request Feb 2, 2017
@bors
Auto merge of #39470 - GuillaumeGomez:rollup, r=GuillaumeGomez
eedaa94 
Rollup of 9 pull requests

- Successful merges: #38823, #39196, #39299, #39319, #39373, #39383, #39416, #39420, #39427
- Failed merges:
@bors bors merged commit 4a07e72 into rust-lang:master Feb 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@BurntSushi BurntSushi

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@federicomenaquintero @rust-highfive @GuillaumeGomez @bors @BurntSushi