Add doc examples for std::ffi::OsString fucntions/methods.
#39221
+73
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
requested changes
Jan 21, 2017
| /// use std::ffi::OsString; | ||
| /// | ||
| /// let os_string = OsString::new(); | ||
| /// ``` | ||
| #[stable(feature = "rust1", since = "1.0.0")] | ||
| pub fn new() -> OsString { | ||
| OsString { inner: Buf::from_string(String::new()) } | ||
| } | ||
|
|
||
| /// Converts to an `OsStr` slice. |
There was a problem hiding this comment.
Can you add the url here please?
There was a problem hiding this comment.
Linking these URLs is tangential to my changes in this pull request.
There was a problem hiding this comment.
Yes but we tend to forget otherwise. However if you open another PR which does it, I'm perfectly fine with it.
| @@ -62,12 +80,32 @@ impl OsString { | |||
| /// Converts the `OsString` into a `String` if it contains valid Unicode data. | |||
| /// let os_string = OsString::from("foo"); | ||
| /// let string = os_string.into_string(); | ||
| /// assert_eq!(string, Ok(String::from("foo"))); | ||
| /// ``` | ||
| #[stable(feature = "rust1", since = "1.0.0")] | ||
| pub fn into_string(self) -> Result<String, OsString> { | ||
| self.inner.into_string().map_err(|buf| OsString { inner: buf} ) | ||
| } | ||
|
|
||
| /// Extends the string with the given `&OsStr` slice. |
|
Thanks a lot for this! Can you add the missing urls as well please? |
frewsxcv
force-pushed
the
os-string-docs
branch
from
e1f7732 to
47143e3
Compare
GuillaumeGomez
approved these changes
Jan 21, 2017
|
Waiting for travis to confirm before r+. Once it's ok, just r=me. |
|
@bors r=GuillaumeGomez |
|
📌 Commit 47143e3 has been approved by |
|
@bors rollup |
bors
added a commit
that referenced
this pull request
Jan 22, 2017
Add doc examples for `std::ffi::OsString` fucntions/methods. None
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.