travis: Add i586 linux and i686 musl #39068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
Collaborator
|
☔ The latest upstream changes (presumably #39042) made this pull request unmergeable. Please resolve the merge conflicts. |
This commit expands the existing x86_64-musl entry in the Travis matrix to also build/test i586-unknown-linux-gnu and i686-unknown-linux-musl. cc rust-lang#38531 Closes rust-lang#39053
alexcrichton
force-pushed
the
more-small-tests
branch
from
173ad8a to
6162637
Compare
brson
reviewed
Jan 18, 2017
| # looking like the register values for ESP/EBP were indeed incorrect (swapped) | ||
| # in the source. Similar commits in libunwind (r280099 and r282589) have noticed | ||
| # this for other platforms, and we just need to realize it for musl linux as | ||
| # well. |
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 6162637 has been approved by |
Collaborator
|
⌛ Testing commit 6162637 with merge 1cf8da1... |
Collaborator
|
💔 Test failed - status-appveyor |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 20, 2017
travis: Add i586 linux and i686 musl This commit expands the existing x86_64-musl entry in the Travis matrix to also build/test i586-unknown-linux-gnu and i686-unknown-linux-musl. cc rust-lang#38531 Closes rust-lang#35599 Closes rust-lang#39053
Member
Author
|
@bors: retry
* network error
…On Fri, Jan 20, 2017 at 8:00 AM, bors ***@***.***> wrote:
💔 Test failed - status-appveyor
<https://ci.appveyor.com/project/rust-lang/rust/build/1.0.1631>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#39068 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95FJ1JbAK3srBrkBGvrZ1HqCdZGoEks5rUNoggaJpZM4LjuTU>
.
|
Member
Author
|
@bors: r-
|
bors
added a commit
that referenced
this pull request
Jan 20, 2017
Rollup of 28 pull requests - Successful merges: #38603, #38761, #38842, #38847, #38955, #38966, #39062, #39068, #39077, #39111, #39112, #39114, #39118, #39120, #39132, #39135, #39138, #39142, #39143, #39146, #39157, #39166, #39167, #39168, #39179, #39184, #39195, #39197 - Failed merges: #39060, #39145
Member
Author
|
With a tip from the #llvm IRC channel looks like all we needed was to enable frame pointers. I have done so and it fixes the failures I previously saw. The fix missed the most recent revision of the rollup, so I'll probably send a follow-up PR to enable testing for i686 musl. |
bors
added a commit
that referenced
this pull request
Jan 21, 2017
Rollup of 28 pull requests - Successful merges: #38603, #38761, #38842, #38847, #38955, #38966, #39062, #39068, #39077, #39111, #39112, #39114, #39118, #39120, #39132, #39135, #39138, #39142, #39143, #39146, #39157, #39166, #39167, #39168, #39179, #39184, #39195, #39197 - Failed merges: #39060, #39145
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 21, 2025
compiletest: Don't set `TARGET` for non run-make tests There are a few tests that were using `TARGET` to quietly do nothing on `i586` targets, but it's cleaner to just add support for `//@ ignore-i586` instead. This lets us get rid of an unsafe `env::set_var` in compiletest, which really should have been setting the environment variable on individual build/run subprocess commands anyway. - The original code and tests were introduced way back in rust-lang#39068
rust-timer
added a commit
that referenced
this pull request
Oct 21, 2025
Rollup merge of #147929 - Zalathar:target, r=jieyouxu compiletest: Don't set `TARGET` for non run-make tests There are a few tests that were using `TARGET` to quietly do nothing on `i586` targets, but it's cleaner to just add support for `//@ ignore-i586` instead. This lets us get rid of an unsafe `env::set_var` in compiletest, which really should have been setting the environment variable on individual build/run subprocess commands anyway. - The original code and tests were introduced way back in #39068
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit expands the existing x86_64-musl entry in the Travis matrix to also
build/test i586-unknown-linux-gnu and i686-unknown-linux-musl.
cc #38531
Closes #35599
Closes #39053