Don't build the lexer verifier during tidy #37867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tidy is not the right place to do this. Tidy is for running lints. We should instead be running the lexer/grammar tests as part of the test suite. This may fix nightly breakage, but I don't know why.
|
I'm running distcheck locally but it will take all day. |
|
@bors: r+ p=1 |
|
📌 Commit d3b050c has been approved by |
bors
added a commit
that referenced
this pull request
Nov 18, 2016
Don't build the lexer verifier during tidy Tidy is not the right place to do this. Tidy is for running lints. We should instead be running the lexer/grammar tests as part of the test suite. This may fix nightly breakage, but I don't understand why. https://buildbot.rust-lang.org/builders/nightly-dist-rustc-linux/builds/715/steps/distcheck/logs/stdio r? @alexcrichton cc @dns2utf8
|
Looks like a runtime error, maybe from one of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tidy is not the right place to do this. Tidy is for running lints.
We should instead be running the lexer/grammar tests as part of the test
suite.
This may fix nightly breakage, but I don't understand why.
https://buildbot.rust-lang.org/builders/nightly-dist-rustc-linux/builds/715/steps/distcheck/logs/stdio
r? @alexcrichton
cc @dns2utf8