Skip to content

Update to new macro url syntax #36535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2016
Merged

Update to new macro url syntax #36535

merged 1 commit into from
Sep 30, 2016

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Sep 16, 2016

Mark-Simulacrum
Mark-Simulacrum approved these changes Sep 16, 2016
View reviewed changes
src/libcore/fmt/mod.rs Outdated
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum Sep 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be changed to "[write!]" instead of [write_macro] while we're here?

Copy link
Member Author

@GuillaumeGomez GuillaumeGomez Sep 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not!

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Sep 16, 2016

Next, I think about removing the actual compatibility with the old url macro syntax. If people have opinion?

@steveklabnik
Copy link
Contributor

steveklabnik commented Sep 17, 2016

Next, I think about removing the actual compatibility with the old url macro syntax. If people have opinion?

we should leave it in for a little while

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Sep 18, 2016

Ok. So I guess this is ready to get merged?

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Sep 24, 2016

@steveklabnik: ping

@steveklabnik
Copy link
Contributor

steveklabnik commented Sep 30, 2016

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 30, 2016

📌 Commit f6ab636 has been approved by steveklabnik

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Sep 30, 2016
@steveklabnik
Rollup merge of rust-lang#36535 - GuillaumeGomez:macro_url, r=stevekl…
dcec48d 
…abnik

Update to new macro url syntax

r? @steveklabnik
@steveklabnik steveklabnik mentioned this pull request Sep 30, 2016
Merged
bors added a commit that referenced this pull request Sep 30, 2016
@bors
Auto merge of #36864 - steveklabnik:rollup, r=steveklabnik
50932b5 
Rollup of 13 pull requests

- Successful merges: #36529, #36535, #36576, #36623, #36711, #36750, #36810, #36829, #36833, #36841, #36842, #36851, #36860
- Failed merges:
@bors bors merged commit f6ab636 into rust-lang:master Sep 30, 2016
@GuillaumeGomez GuillaumeGomez deleted the macro_url branch October 1, 2016 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum approved these changes

Assignees

@steveklabnik steveklabnik

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GuillaumeGomez @steveklabnik @bors @Mark-Simulacrum