-
Notifications
You must be signed in to change notification settings - Fork 13.4k
doc: Insert examples with universal function call syntax #36248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
In my opinion, I don't think we need to display both the method call syntax and the UFCS syntax, it seems redundant. |
In my opinion the examples are mainly for persons new to rust, which may not yet know about UFCS. In the example for atan2 I did not add any lines of code, do you think that is OK? |
Currently the example for atan2 explains the implementation. |
Thanks for the PR, but I have to agree with @frewsxcv: this is not the place to teach UFCS. In addition, while the method notation may seem strange from a mathematical standpoint, it was a choice made in the API design (as opposed to using free functions) and we should present the API as intended to be used. I'm going to close this out for the time being. |
No description provided.