Skip to content

Updated test for E0221 #35770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2016
Merged

Updated test for E0221 #35770

merged 2 commits into from
Aug 18, 2016

Conversation

tvladyslav
Copy link
Contributor

As a part of issue #35233
?r @GuillaumeGomez

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@sophiajt
Copy link
Contributor

Ahh, didn't realize that test hadn't been updated. Good catch.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 17, 2016

📌 Commit de5aaee has been approved by jonathandturner

@sophiajt
Copy link
Contributor

@bors r-

Actually, before this gets committed, you'll need to run:

python src/bootstrap/bootstrap.py --stage 1 --step check-tidy

And fix the errors tidy gives you. It seems like you might have some extra spaces in there.

@tvladyslav
Copy link
Contributor Author

check-tidy fails to run. I'm running python src/bootstrap/bootstrap.py --clean second time. Hopefully it will help.
And yes, there was a space.

@tvladyslav
Copy link
Contributor Author

@jonathandturner Now should be OK.

@sophiajt
Copy link
Contributor

Thanks.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 17, 2016

📌 Commit ed54226 has been approved by jonathandturner

eddyb added a commit to eddyb/rust that referenced this pull request Aug 18, 2016
@bors bors merged commit ed54226 into rust-lang:master Aug 18, 2016
@tvladyslav tvladyslav deleted the E0221 branch August 18, 2016 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants