Skip to content

Add x86 intrinsics for bit manipulation (BMI 1.0, BMI 2.0, and TBM). #34412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 5, 2016
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Allow different instruction set prefixes within the same architecture
  • Loading branch information
gnzlbg committed Jun 22, 2016
commit 152055451c552121be35a179bb77194e02800baa
4 changes: 2 additions & 2 deletions src/etc/platform-intrinsics/aarch64.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"platform": "aarch64",
"intrinsic_prefix": "aarch64_v",
"platform": "aarch64_v",
"intrinsic_prefix": "",
"llvm_prefix": "llvm.aarch64.neon.",
"number_info": {
"signed": {
Expand Down
4 changes: 2 additions & 2 deletions src/etc/platform-intrinsics/arm.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"platform": "arm",
"intrinsic_prefix": "arm_v",
"platform": "arm_v",
"intrinsic_prefix": "",
"llvm_prefix": "llvm.neon.v",
"number_info": {
"signed": {
Expand Down
27 changes: 19 additions & 8 deletions src/etc/platform-intrinsics/generator.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,18 +26,19 @@
class PlatformInfo(object):
def __init__(self, json):
self._platform = json['platform']
self._intrinsic_prefix = json['intrinsic_prefix']

def intrinsic_prefix(self):
return self._intrinsic_prefix
def platform_prefix(self):
return self._platform

class IntrinsicSet(object):
def __init__(self, platform, json):

self._llvm_prefix = json['llvm_prefix']
self._type_info = json['number_info']
self._intrinsics = json['intrinsics']
self._widths = json['width_info']
self._platform = platform
self._intrinsic_prefix = json['intrinsic_prefix']

def intrinsics(self):
for raw in self._intrinsics:
Expand All @@ -48,6 +49,9 @@ def intrinsics(self):
def platform(self):
return self._platform

def intrinsic_prefix(self):
return self._intrinsic_prefix

def llvm_prefix(self):
return self._llvm_prefix

Expand Down Expand Up @@ -538,8 +542,14 @@ def intrinsic_suffix(self):
*self._args,
width = self._width)

def platform_prefix(self):
return self._platform.platform().platform_prefix()

def intrinsic_set_name(self):
return self._platform.intrinsic_prefix()

def intrinsic_name(self):
return self._platform.platform().intrinsic_prefix() + self.intrinsic_suffix()
return self._platform.intrinsic_prefix() + self.intrinsic_suffix()

def compiler_args(self):
return ', '.join(arg.compiler_ctor_ref() for arg in self._args_raw)
Expand Down Expand Up @@ -751,8 +761,9 @@ def open(self, platform):
return 'extern "platform-intrinsic" {'

def render(self, mono):
return ' fn {}{};'.format(mono.intrinsic_name(),
mono.intrinsic_signature())
return ' fn {}{}{};'.format(mono.platform_prefix(),
mono.intrinsic_name(),
mono.intrinsic_signature())

def close(self):
return '}'
Expand Down Expand Up @@ -786,15 +797,15 @@ def open(self, platform):
#[inline(never)]
pub fn find(name: &str) -> Option<Intrinsic> {{
if !name.starts_with("{0}") {{ return None }}
Some(match &name["{0}".len()..] {{'''.format(platform.intrinsic_prefix())
Some(match &name["{0}".len()..] {{'''.format(platform.platform_prefix())

def render(self, mono):
return '''\
"{}" => Intrinsic {{
inputs: {{ static INPUTS: [&'static Type; {}] = [{}]; &INPUTS }},
output: {},
definition: Named("{}")
}},'''.format(mono.intrinsic_suffix(),
}},'''.format(mono.intrinsic_set_name() + mono.intrinsic_suffix(),
len(mono._args_raw),
mono.compiler_args(),
mono.compiler_ret(),
Expand Down
1 change: 1 addition & 0 deletions src/etc/platform-intrinsics/x86/avx.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"intrinsic_prefix": "_mm",
"llvm_prefix": "llvm.x86.avx.",
"intrinsics": [
{
Expand Down
1 change: 1 addition & 0 deletions src/etc/platform-intrinsics/x86/avx2.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"intrinsic_prefix": "_mm",
"llvm_prefix": "llvm.x86.avx2.",
"intrinsics": [
{
Expand Down
1 change: 1 addition & 0 deletions src/etc/platform-intrinsics/x86/fma.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"intrinsic_prefix": "_mm",
"llvm_prefix": "llvm.x86.fma.",
"intrinsics": [
{
Expand Down
6 changes: 5 additions & 1 deletion src/etc/platform-intrinsics/x86/info.json
Original file line number Diff line number Diff line change
@@ -1,26 +1,30 @@
{
"platform": "x86",
"intrinsic_prefix": "x86_mm",
"number_info": {
"signed": {
"kind": "s",
"kind_short": "",
"data_type": { "pattern": "epi{bitwidth}" },
"bitwidth": { "pattern": "{bitwidth}" },
"data_type_short": { "8": "b", "16": "w", "32": "d", "64": "q" }
},
"unsigned": {
"kind": "u",
"kind_short": "u",
"data_type": { "pattern": "epu{bitwidth}" },
"bitwidth": { "pattern": "{bitwidth}" },
"data_type_short": { "8": "b", "16": "w", "32": "d", "64": "q" }
},
"float": {
"kind": "f",
"data_type": { "32": "ps", "64": "pd" },
"bitwidth": { "pattern": "{bitwidth}" },
"data_type_short": { "32": "ps", "64": "pd" }
}
},
"width_info": {
"32": { "width_mm": "32", "width_suffix": "" },
"64": { "width_mm": "64", "width_suffix": "" },
"128": { "width_mm": "", "width_suffix": "" },
"256": { "width_mm": "256", "width_suffix": ".256" },
"512": { "width_mm": "512", "width_suffix": ".512" }
Expand Down
1 change: 1 addition & 0 deletions src/etc/platform-intrinsics/x86/sse.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"intrinsic_prefix": "_mm",
"llvm_prefix": "llvm.x86.sse.",
"intrinsics": [
{
Expand Down
1 change: 1 addition & 0 deletions src/etc/platform-intrinsics/x86/sse2.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"intrinsic_prefix": "_mm",
"llvm_prefix": "llvm.x86.sse2.",
"intrinsics": [
{
Expand Down
1 change: 1 addition & 0 deletions src/etc/platform-intrinsics/x86/sse3.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"intrinsic_prefix": "_mm",
"llvm_prefix": "llvm.x86.sse3.",
"intrinsics": [
{
Expand Down
1 change: 1 addition & 0 deletions src/etc/platform-intrinsics/x86/sse41.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"intrinsic_prefix": "_mm",
"llvm_prefix": "llvm.x86.sse41.",
"intrinsics": [
{
Expand Down
1 change: 1 addition & 0 deletions src/etc/platform-intrinsics/x86/sse42.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"intrinsic_prefix": "_mm",
"llvm_prefix": "llvm.x86.sse42.",
"intrinsics": [
{
Expand Down
1 change: 1 addition & 0 deletions src/etc/platform-intrinsics/x86/ssse3.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"intrinsic_prefix": "_mm",
"llvm_prefix": "llvm.x86.ssse3.",
"intrinsics": [
{
Expand Down