Skip to content

Implement Binary, Octal, LowerHex and UpperHex for Wrapping<T> #34190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2016
Merged

Implement Binary, Octal, LowerHex and UpperHex for Wrapping<T> #34190

merged 1 commit into from
Jun 22, 2016

Conversation

ollie27
Copy link
Contributor

@ollie27 ollie27 commented Jun 9, 2016

Fixes: #33659

@rust-highfive
Copy link
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton alexcrichton added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Jun 10, 2016
@alexcrichton
Copy link
Member

The libs team discussed this PR during triage today and the conclusion was to merge. Thanks again for the PR @ollie27!

@alexcrichton alexcrichton reopened this Jun 21, 2016
@alexcrichton
Copy link
Member

@bors: r+ ee46905

oops

Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 22, 2016
@Manishearth
Rollup merge of rust-lang#34190 - ollie27:wrapping_fmt, r=alexcrichton
ae235ae 
Implement Binary, Octal, LowerHex and UpperHex for Wrapping<T>

Fixes: rust-lang#33659
Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 22, 2016
@Manishearth
Rollup merge of rust-lang#34190 - ollie27:wrapping_fmt, r=alexcrichton
e4ff7f0 
Implement Binary, Octal, LowerHex and UpperHex for Wrapping<T>

Fixes: rust-lang#33659
@Manishearth Manishearth mentioned this pull request Jun 22, 2016
Merged
bors added a commit that referenced this pull request Jun 22, 2016
@bors
Auto merge of #34408 - Manishearth:rollup, r=Manishearth
e41cdab 
Rollup of 7 pull requests

- Successful merges: #34190, #34363, #34367, #34383, #34387, #34394, #34404
- Failed merges:
@bors bors merged commit ee46905 into rust-lang:master Jun 22, 2016
@ollie27 ollie27 deleted the wrapping_fmt branch June 22, 2016 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brson brson

Labels
T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ollie27 @rust-highfive @alexcrichton @brson @bors