[MIR] Add PointerCast for Unsize casts of fat pointers. #33734
Conversation
| @@ -268,6 +269,20 @@ impl Type { | |||
| } | |||
| } | |||
|
|
|||
| pub fn fat_ptr_data_type(&self) -> Type { | |||
There was a problem hiding this comment.
This is actually type_of::in_memory_type_of.
There was a problem hiding this comment.
Ah, I looked in type_ but not type_of I guess.
There was a problem hiding this comment.
Actually, type_of::in_memory_type_of isn't what I want. For &Trait it returns {T*, (vtable)} whereas I'm only trying to cast the base and thus want just T*.
There was a problem hiding this comment.
You'd want to call it on the pointee type, which you can easy get, by changing the second &ty::TyRawPtr(..) pattern to &ty::TyRawPtr(mt) and using mt.ty.
There was a problem hiding this comment.
Ok, just pulled that out into type_of::fat_ptr_base_ty since I need to call it from 2 different places and the second is not already within a match giving easy access to mt.ty.
|
LGTM, except for using LLVM to get at information we already have. |
luqmana
force-pushed
the
33387-mir_fat_ptr_coerce
branch
from
9b49c4c
to
94f0918
Compare
|
@bors r+ rollup |
|
📌 Commit 94f0918 has been approved by |
…=arielb1 [MIR] Add PointerCast for Unsize casts of fat pointers. Fixes rust-lang#33387. r? @eddyb
Fixes #33387.
r? @eddyb