resolve: print location of static for "static in pattern" error #33340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Aatch (rust_highfive has picked a reviewer for you, use r? to override) |
| // option. This file may not be copied, modified, or distributed | ||
| // except according to those terms. | ||
|
|
||
| static foo: i32 = 0; |
There was a problem hiding this comment.
test for the import resolution? r=me with or without fix
|
@bors delegate+ r=Manishearth this once you add the test. |
|
✌️ @birkenfeld can now approve this pull request |
|
@Manishearth sorry, what exactly do I do? |
|
yes, with an o instead of a 0 |
that was intentional to avoid triggering it - I don't know how zealous it is in parsing these comments :) |
The implementation mirrors the one for "constant defined here" annotation used for constant patterns in the irrefutable-pattern case. Fixes: rust-lang#23716
|
@bors r=Manishearth |
|
📌 Commit 4ba6bf4 has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 3, 2016
resolve: print location of static for "static in pattern" error The implementation mirrors the one for "constant defined here" annotation used for constant patterns in the irrefutable-pattern case. Fixes: rust-lang#23716
bors
added a commit
that referenced
this pull request
May 3, 2016
bors
added a commit
that referenced
this pull request
May 3, 2016
bors
added a commit
that referenced
this pull request
May 4, 2016
bors
added a commit
that referenced
this pull request
May 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation mirrors the one for "constant defined here" annotation used for constant patterns in the irrefutable-pattern case.
Fixes: #23716