Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typeck: show a note about tuple indexing for erroneous tup[i] #33337

Merged
merged 1 commit into from
May 10, 2016
Merged

typeck: show a note about tuple indexing for erroneous tup[i] #33337

merged 1 commit into from
May 10, 2016

Conversation

birkenfeld
Copy link
Contributor

Fixes: #27842

@rust-highfive
Copy link
Collaborator

r? @Aatch

(rust_highfive has picked a reviewer for you, use r? to override)

Manishearth
Manishearth reviewed May 2, 2016
View reviewed changes
src/test/compile-fail/issue-27842.rs
// the case where we show a suggestion
let _ = tup[0];
//~^ ERROR cannot index a value of type
//~| HELP to access tuple elements, use tuple indexing syntax as shown
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compiletest supports SUGGESTION btw, could you add that entry here? r=me regardless

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do

@birkenfeld
Copy link
Contributor Author

r? @Manishearth

@rust-highfive rust-highfive assigned Manishearth and unassigned Aatch May 2, 2016
@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented May 2, 2016

📌 Commit 8d688e6 has been approved by Manishearth

@bors
Copy link
Contributor

bors commented May 3, 2016

⌛ Testing commit 8d688e6 with merge e2cf62e...

@Manishearth Manishearth closed this May 3, 2016
@bors
Copy link
Contributor

bors commented May 3, 2016

⛄ The build was interrupted to prioritize another pull request.

@Manishearth Manishearth reopened this May 3, 2016
@jseyfried
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented May 10, 2016

📌 Commit b48b509 has been approved by jseyfried

@bors
Copy link
Contributor

bors commented May 10, 2016

⌛ Testing commit b48b509 with merge 3585321...

bors added a commit that referenced this pull request May 10, 2016
@bors
Auto merge of #33337 - birkenfeld:issue-27842, r=jseyfried
3585321 
typeck: show a note about tuple indexing for erroneous tup[i]

Fixes: #27842
@bors
Copy link
Contributor

bors commented May 10, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-32cross-opt, auto-linux-64-cargotest, auto-linux-64-cross-armhf, auto-linux-64-cross-armsf, auto-linux-64-cross-freebsd, auto-linux-64-cross-netbsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-cross-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild

@bors bors merged commit b48b509 into rust-lang:master May 10, 2016
@birkenfeld birkenfeld deleted the issue-27842 branch May 12, 2016 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@birkenfeld @rust-highfive @Manishearth @bors @jseyfried @Aatch