Skip to content

Conversation

@tclfs
Copy link
Contributor

@tclfs tclfs commented Mar 26, 2016

(1) In contrast to that, so that expresses result indicated by the sentence, not reason;
(2) block is an expression, and may be have an expression, so I add optionally an expression to make more precise;
(3) When I read here, I was confused with what the child referred to. After modification, it would be better.

(1) In contrast to `that`, `so that` expresses `result` indicated by the sentence, not `reason`;
(2) `block` is an expression, and may be have an expression, so I add `optional an expression` to make more precise;
(3) When I read here, I was confused with what `the child` referred to. After modification, it would be better.
@rust-highfive
Copy link
Contributor

r? @steveklabnik

(rust_highfive has picked a reviewer for you, use r? to override)

* `pat`: a pattern. Examples: `Some(t)`; `(17, 'a')`; `_`.
* `stmt`: a single statement. Example: `let x = 3`.
* `block`: a brace-delimited sequence of statements. Example:
* `block`: a brace-delimited sequence of statements and optional an expression. Example:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be "optionally"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right. Thanks for your suggestion.

@steveklabnik
Copy link
Contributor

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 28, 2016

📌 Commit 708c5d0 has been approved by steveklabnik

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Mar 28, 2016
docs: make some text changes on Section `Macros`

(1) In contrast to `that`, `so that` expresses `result` indicated by the sentence, not `reason`;
(2) `block` is an expression, and may be have an expression, so I add `optionally an expression` to make more precise;
~~(3) When I read here, I was confused with what `the child` referred to. After modification, it would be better.~~
bors added a commit that referenced this pull request Mar 28, 2016
Rollup of 7 pull requests

- Successful merges: #32177, #32235, #32472, #32504, #32507, #32509, #32534
- Failed merges:
@bors bors merged commit 708c5d0 into rust-lang:master Mar 28, 2016
@tclfs tclfs deleted the patch-2 branch March 29, 2016 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants