Pretty printing brackets on match arms #3194
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the pretty printer prints the brackets for match arms (if they are blocks) on a new line. This means you get something like (omitting a bunch of repetitions to make it not all fit inline):
This is because the block is printed with print_expr, which means the whole thing is wrapped inside of a box. What should happen is that the opening bracket should be in the head box with "something =>" (that's how it works elsewhere). With the code in this pull request, the same code is formatted as:
Which seems better.
Edit: Now that incoming is not burning, I can confirm that the code here does not cause any test failures.