Implement ToSocketAddrs for &[SocketAddr] #31161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
I think |
alexcrichton
added
the
T-libs-api
sfackler
force-pushed
the
slice-to-socket-addrs
branch
from
aac518b to
783a0ba
Compare
| @@ -457,6 +459,15 @@ impl ToSocketAddrs for str { | |||
| } | |||
| } | |||
|
|
|||
| #[stable(feature = "slice-to-socket-addrs", since = "1.8.0")] | |||
There was a problem hiding this comment.
Currently we require feature names to be valid rust identifiers, so could this change - to _?
|
The libs team discussed this during triage today and the decision was that this seems like fine functionality to have. r=me with the minor nit update (which I think made travis fail?) |
alexcrichton
removed
I-needs-decision
sfackler
force-pushed
the
slice-to-socket-addrs
branch
from
783a0ba to
7ea0abf
Compare
|
@bors r=alexcrichton |
|
📌 Commit 7ea0abf has been approved by |
bors
added a commit
that referenced
this pull request
Feb 4, 2016
This is useful when you have an API that takes a `T: ToSocketAddrs` and needs to turn that into an owned value which will be passed to another API taking `T: ToSocketAddrs` at a later time, for example: https://github.com/sfackler/rust-hyper-socks/blob/master/src/lib.rs#L15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful when you have an API that takes a
T: ToSocketAddrsand needs to turn that into an owned value which will be passed to another API takingT: ToSocketAddrsat a later time, for example: https://github.com/sfackler/rust-hyper-socks/blob/master/src/lib.rs#L15