Rollup of 10 pull requests #30750
Merged
Rollup of 10 pull requests #30750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
steveklabnik
commented
Jan 6, 2016
steveklabnik
commented
- Successful merges: Correct formatting use of tab instead of spaces #30683, Update MinGW details in the README #30698, Mention that structs can contain &mut Ts #30699, Mention that Sync/Send are automatically derived #30700, Fix the spelling of "hexadecimal" #30716, Clarify What LIFO Is #30720, Clarify how Rust treats backslashes at end of line in string literals #30727, Remove irrelevant comment #30729, Nomicon: wrong type in Vec deallocation example #30735, Fix error in example code #30749
- Failed merges:
Declare what LIFO stands for
Rust differs in that behavior from C: In C, the newline escapes are resolved
before anything else, and in Rust this depends on whether the backslash is
escaped itself.
A difference can be observed in the following two programs:
```c
#include <stdio.h>
int main()
{
printf("\\
n\n");
return 0;
}
```
```rust
fn main() {
println!("\\
n");
}
```
The first program prints two newlines, the second one prints a backslash, a
newline, the latin character n and a final newline.
The fundamental problem of duplication was fixed in rust-lang#10891, but the comment was preserved. Closes rust-lang#9762.
…nal code is correct, the example here would not compile without the cast. I used *mut _ instead of *mut u8 to be consistent with the final code.
…bnik I noticed the alignment was off in the error handling part of the book. This was caused because two tabs had crept into the file. I have changed these for spaces.
Declare what LIFO stands for
…eklabnik
Rust differs in that behavior from C: In C, the newline escapes are resolved
before anything else, and in Rust this depends on whether the backslash is
escaped itself.
A difference can be observed in the following two programs:
```c
int main()
{
printf("\\
n\n");
return 0;
}
```
```rust
fn main() {
println!("\\
n");
}
```
The first program prints two newlines, the second one prints a backslash, a
newline, the latin character n and a final newline.
The fundamental problem of duplication was fixed in rust-lang#10891, but the comment was preserved. Closes rust-lang#9762.
…er_type, r=steveklabnik heap::deallocate expects a *mut u8, but here a *mut T is given as the type of the argument. This would not compile. The final code is correct, however.
Contributor
Author
|
@bors: r+ p=1 |
Collaborator
|
📌 Commit 6cca775 has been approved by |
Contributor
|
r? @Manishearth (rust_highfive has picked a reviewer for you, use r? to override) |
Collaborator
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.