-
Couldn't load subscription status.
- Fork 13.9k
Fix a breaking change in #30523 #30733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
While this does fix a breaking change, it is also, technically, a [breaking-change] to go back to our original way
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Note, this was discovered in #30713. |
|
@bors r+ p=1 |
|
📌 Commit 14e1e2a has been approved by |
|
⌛ Testing commit 14e1e2a with merge e5817d0... |
|
💔 Test failed - auto-linux-32-opt |
|
|
@bors retry |
|
It would be nice to add test which failed with the new version, no? |
Fix a breaking change in #30523 While this does fix a breaking change, it is also, technically, a [breaking-change] to go back to our original way
|
It would be good to have a test case, I agree. |
Fix a breaking change in #30523
While this does fix a breaking change, it is also, technically, a
[breaking-change] to go back to our original way