f32: inline methods with special variant for msvc #30719
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@bors r+ |
|
📌 Commit a4865de has been approved by |
|
⌛ Testing commit a4865de with merge 3420e99... |
|
💔 Test failed - auto-mac-64-nopt-t |
| #[cfg(not(target_env = "msvc"))] | ||
| fn log10f(f: f32) -> f32 { unsafe { intrinsics::log10f32(f) } } | ||
| return unsafe { intrinsics::log10f32(f) }; |
|
Fixed float methods. Build passes. |
|
\o/ On Fri, Jan 8, 2016 at 3:08 AM, Pyfisch notifications@github.com wrote:
|
|
💔 Test failed - auto-mac-64-nopt-t |
|
@bors: retry On Tue, Jan 12, 2016 at 9:16 AM, bors notifications@github.com wrote:
|
|
⚡ Previous build results for auto-linux-cross-opt are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt... |
No description provided.