Don't throw away item attributes before trans_fn() for generic functions and others. #30661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
…is correctly executed.
michaelwoerister
force-pushed
the
trans_fn_attrs
branch
from
43844a2 to
ff93fc8
Compare
|
Looks generally good to me, but I’d like a separate issue for that MIR thing filled (it is much easier to work when you can just pick an arbitrary issue with |
|
@bors: r+ |
|
📌 Commit ff93fc8 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 4, 2016
So far `librustc::trans::base::trans_fn()` and `trans_closure()` have been passed the list of attributes on the function being translated *only* if the function was local and non-generic. For generic functions, functions inlined from other crates, functions with foreign ABI and for closures, only an empty list of attributes was ever passed to `trans_fn()`. This led to the case that generic functions marked with `#[rustc_mir]` where not actually translated via MIR but via the legacy translation path. This PR makes function/closure attributes always be passed to `trans_fn()` and disables the one test where this makes a difference. If there is an actual reason why attributes were not passed along in these cases, let me know. cc @rust-lang/compiler cc @luqmana regarding the test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far
librustc::trans::base::trans_fn()andtrans_closure()have been passed the list of attributes on the function being translated only if the function was local and non-generic. For generic functions, functions inlined from other crates, functions with foreign ABI and for closures, only an empty list of attributes was ever passed totrans_fn().This led to the case that generic functions marked with
#[rustc_mir]where not actually translated via MIR but via the legacy translation path.This PR makes function/closure attributes always be passed to
trans_fn()and disables the one test where this makes a difference.If there is an actual reason why attributes were not passed along in these cases, let me know.
cc @rust-lang/compiler
cc @luqmana regarding the test case