Skip to content

First draft at constructing a dependency graph #30393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

First draft at constructing a dependency graph #30393

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
535fcd4
Add the core dependency graph data structure into
nikomatsakis Dec 15, 2015
314aaf9
Add the rustc tooling for dependency graph checking.
nikomatsakis Dec 15, 2015
f3d8be1
Add a `MemoizationMap` and use it to generalize memoization
nikomatsakis Dec 15, 2015
894152f
Change two maps over to DepTrackingMaps
nikomatsakis Dec 15, 2015
ed71ba4
Remove trait collection phase, which is not needed.
nikomatsakis Dec 15, 2015
47f1494
Instrument the passes to push/pop what we are currently doing.
nikomatsakis Dec 15, 2015
9413fc8
Add unit-testing framework for dep graph and `-Z dump-dep-graph`
nikomatsakis Dec 15, 2015
5668191
Workaround stage0 bug
nikomatsakis Dec 15, 2015
e05b8c6
WIP -- librustc_trans -- Fix merge conflict and remove a use of ignor…
nikomatsakis Dec 15, 2015
9507e19
Microoptimize DepNode copy and clone
nikomatsakis Dec 15, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
WIP -- librustc_trans -- Fix merge conflict and remove a use of ignor… 
…e while we're at it
  • Loading branch information
@nikomatsakis
nikomatsakis committed Dec 15, 2015
commit e05b8c6180969d61bd45a0e50fade02b4a767ec1
1 change: 1 addition & 0 deletions src/librustc/dep_graph/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ pub enum DepNode {
TransLinkMeta,
TransCrateItem(DefId),
TransInlinedItem(DefId),
TransWriteMetadata,

// Nodes representing bits of computed IR in the tcx. Each of
// these corresponds to a particular table in the tcx.
Expand Down
5 changes: 3 additions & 2 deletions src/librustc_trans/trans/base.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3060,8 +3060,9 @@ pub fn trans_crate<'tcx>(tcx: &ty::ctxt<'tcx>,
let reachable_symbol_ids = filter_reachable_ids(&shared_ccx);

// Translate the metadata.
let metadata = tcx.dep_graph.with_ignore(|| {
write_metadata(&shared_ccx, krate, &reachable_symbol_ids, mir_map);
let metadata = tcx.dep_graph.with_task(DepNode::TransWriteMetadata, || {
let krate = tcx.map.krate();
write_metadata(&shared_ccx, krate, &reachable_symbol_ids, mir_map)
});

if shared_ccx.sess().trans_stats() {
Expand Down