Fixed regression in associated item resolution #28395
Conversation
…meters that reference Self in traits.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| ty_param_defs | ||
| .iter() | ||
| .map(|p| this.ty_infer(Some(p.clone()), Some(&mut substs), Some(TypeSpace), span)) | ||
| .map(|p| { |
There was a problem hiding this comment.
This code rather needs some refactoring (at least, split it into another method).
…rence non-existant self
|
r? @nrc |
| @@ -412,10 +412,26 @@ fn create_substs_for_ast_path<'tcx>( | |||
| // they were optional (e.g. paths inside expressions). | |||
There was a problem hiding this comment.
I would have extracted the entire is_empty() line
|
@bors r+ 4fec679 |
|
⌛ Testing commit 4fec679 with merge 3332ae5... |
|
💔 Test failed - auto-linux-64-x-android-t |
|
@bors: retry On Mon, Sep 14, 2015 at 6:39 AM, bors notifications@github.com wrote:
|
|
⌛ Testing commit 4fec679 with merge a7b3eed... |
|
This is a 1.2-1.3 regression (#27591 is a runnable example) - may be worth backporting |
|
We're currently very close to 1.3 being released, so while not impossible it would be difficult to backport more PRs. With that in mind, it looks like this is just improving an ICE to be a first-class error message instead? Is there code that compiles on stable which does not compile on nightly right now? If it's just an improvement to the error message I'm inclined to not backport this as it's so close to the release, but it's not clear to me if that's the only part which was fixed. |
|
Yes, this only improves diagnostics. |
brson
added
I-needs-decision
|
cc @rust-lang/compiler @rust-lang/lang this was suggested for backporting to 1.3, which we are building today. Needs decision fast. |
|
Note that most of the code in this diff is tests. I am reasonably comfortable backporting. |
|
I recommend against backporting (this late). In the best case scenario this only affects diagnostics. Most of the code is tests, but this area of the code was not well tested before this change. |
|
I also don't feel comfortable backporting. |
|
The code in #27591 is an rpass example of this, but I guess too late. |
alexcrichton
added
T-lang
|
Removing beta-nominated as the release was made |
Fixes #28344