Add note for possible crate mismatches in type errors

[Manishearth]

Partially fixes #22750

I'll write a test for this when I figure out how to.

r? @eddyb

cc @steveklabnik

[steveklabnik]

IIRC all FIXMEs should have an associated issue

[Manishearth]

fixed, it's the same bug (since this is only a partial fix)

[steveklabnik]

So excited for this patch to land!

The messages look good to me.

[eddyb]

You should check that the crates are different - for example:

fn main() {
    let _ = [{struct Foo; Foo}, {struct Foo; Foo}];
}

The error in the above code will see the path "main::Foo" for both of the two different types.

[eddyb]

You'll want to look up the crate names from the crate numbers in the DefIds (and/or find the subset of the path which refers to the extern crate item).

[Manishearth]

Done

[eddyb]

@bors r+

[bors]

📌 Commit c65d338 has been approved by eddyb

[bors]

⌛ Testing commit c65d338 with merge 7c8ae60...

[bors]

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt