Add a allow_asm option so virtual ISA based targets (JS/PNaCl/WAsm) can disallow the asm! macro.
#27927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Aatch (rust_highfive has picked a reviewer for you, use r? to override) |
DiamondLovesYou
force-pushed
the
no-asm
branch
from
68ad64f to
2aeb0da
Compare
| @@ -168,6 +168,8 @@ pub struct TargetOptions { | |||
| /// currently only "gnu" is used to fall into LLVM. Unknown strings cause | |||
| /// the system linker to be used. | |||
| pub archive_format: String, | |||
| /// Is asm!() not allowed? Defaults to false | |||
| pub no_asm: bool, | |||
There was a problem hiding this comment.
Could this instead be inverted to allow_asm? Reading a double negative is sometimes a little confusing. Other than that though looks good to me!
There was a problem hiding this comment.
Fair enough. Done.
… can disallow the asm! macro.
DiamondLovesYou
force-pushed
the
no-asm
branch
from
2aeb0da to
8b70e1e
Compare
DiamondLovesYou
changed the title
no_asm option for virtual ISA based targets (JS/PNaCl/WAsm).allow_asm option so virtual ISA based targets (JS/PNaCl/WAsm) can disallow the asm! macro.
bors
added a commit
that referenced
this pull request
Aug 23, 2015
|
Why would |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.