Small drop glue fixes #27618
Merged
Small drop glue fixes #27618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code to get the LLVM type signature for the drop function doesn't handle unsized types correctly.
Instead of the actual return type, we're currently passing the function type to get_extern_fn(). The only reason this doesn't explode is because get_extern_fn() actually doesn't care about the actual return type, just about it being converging or not.
Contributor
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
Collaborator
|
⌛ Testing commit f804872 with merge 38b6b49... |
Collaborator
|
💔 Test failed - auto-linux-32-opt |
Contributor
Author
|
@bors retry |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Aug 12, 2015
Collaborator
|
⌛ Testing commit f804872 with merge daf7fe9... |
Collaborator
|
⛄ The build was interrupted to prioritize another pull request. |
Collaborator
|
⌛ Testing commit f804872 with merge ad6fa04... |
Collaborator
|
⛄ The build was interrupted to prioritize another pull request. |
Collaborator
bors
added a commit
that referenced
this pull request
Aug 12, 2015
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.