Fix de-deduplication for closure debuginfo #27346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closure variables represent the closure environment, not the closure function, so the identifier used to ensure that the debuginfo is unique for each kind of closure needs to be based on the closure upvars and not the function signature.
Contributor
|
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
Author
Member
|
Thanks for the PR! I'll take a look at this as soon as I find the time. —Reply to this email directly or view it on GitHub. |
Member
|
@bors: r+ |
Collaborator
|
📌 Commit 218eccf has been approved by |
Member
|
Thanks, this is certainly more correct than what we do now, especially after closure type descriptions have been fixed. |
Collaborator
bors
added a commit
that referenced
this pull request
Jul 29, 2015
Closure variables represent the closure environment, not the closure function, so the identifier used to ensure that the debuginfo is unique for each kind of closure needs to be based on the closure upvars and not the function signature.
Collaborator
Member
|
👌🐤👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closure variables represent the closure environment, not the closure
function, so the identifier used to ensure that the debuginfo is unique
for each kind of closure needs to be based on the closure upvars and not
the function signature.