Add E0327, E0395 and E0396 error explanations #26542
Conversation
|
r? @Manishearth |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
GuillaumeGomez
changed the title
|
Part of #24407. |
| // error: raw pointers cannot be compared in statics! | ||
| ``` | ||
|
|
||
| To fix this error, please not assign this value to a constant expression. |
There was a problem hiding this comment.
s/please not/please do not/
|
Updated! |
| // error: raw pointers cannot be compared in statics! | ||
| ``` | ||
|
|
||
| To fix this error, please do not assign this value to a constant |
There was a problem hiding this comment.
This is not the fix.
Avoid recommending catchall fixes like this, since they're not applicable to all situations (but the language makes them sound like it)
Mention common causes and suggest fixes for those instead.
GuillaumeGomez
force-pushed
the
patch-2
branch
2 times, most recently
from
e724c5c to
5bc4557
Compare
|
@Manishearth: Updated. Does the new message seem good to you ? |
GuillaumeGomez
changed the title
|
cc @nagisa |
|
Looks OK at a glance. |
|
r+ ? |
| @@ -1457,6 +1457,42 @@ impl Foo for Bar { | |||
| ``` | |||
| "##, | |||
|
|
|||
| E0327: r##" | |||
| You cannot use a method instead of a constant expression as a pattern. Example | |||
There was a problem hiding this comment.
Technically, "You cannot use associated items other than constant items as patterns. This includes method items". (methods aren't the only associated items)
|
r=me post squash |
|
@Manishearth: Yes, sure. Thanks for your help! |
|
@Manishearth: Squashed ! |
|
@bors r+ rollup |
|
📌 Commit 7b4eb1a has been approved by |
No description provided.