Skip to content

fixes __morestack symbol problem on BSDs #26197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2015
Merged

fixes __morestack symbol problem on BSDs #26197

merged 1 commit into from
Jun 11, 2015

Conversation

dhuseby
Copy link

@dhuseby dhuseby commented Jun 11, 2015

Revision 021e483 broke the BSD builds. This fixes it for Bitrig and probably the others.

@rust-highfive
Copy link
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@brson
Copy link
Contributor

brson commented Jun 11, 2015

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 11, 2015

📌 Commit 5b2edcd has been approved by brson

@@ -17,7 +17,7 @@ using namespace llvm::sys;
using namespace llvm::object;

// libmorestack is not used on Windows
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comment needs an update?

@semarie
Copy link
Contributor

semarie commented Jun 11, 2015

@dhuseby if posible, could you include OpenBSD in the list ?
&& !defined(__OpenBSD__)

else I will rebase my PR after your to be include.

bors added a commit that referenced this pull request Jun 11, 2015
Revision 021e483 broke the BSD builds.  This fixes it for Bitrig and probably the others.
@bors
Copy link
Collaborator

bors commented Jun 11, 2015

⌛ Testing commit 5b2edcd with merge c85f307...

@bors bors merged commit 5b2edcd into rust-lang:master Jun 11, 2015
@dhuseby
Copy link
Author

dhuseby commented Jun 11, 2015

@semarie yup, I'll add it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants