Skip to content

syntax: Remove unused packed attribute - #25541

Merged
bors merged 1 commit into
rust-lang:masterfrom
klutzy:remove-packed-attr
May 18, 2015
Merged

syntax: Remove unused packed attribute#25541
bors merged 1 commit into
rust-lang:masterfrom
klutzy:remove-packed-attr

Conversation

@klutzy

@klutzy klutzy commented May 17, 2015

Copy link
Copy Markdown
Contributor

The attribute was removed by #16499.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton

Copy link
Copy Markdown
Member

Hm, so technically this is a breaking change as any existing #[packed] attributes will start to be an error instead of being silently ignored, but I believe that this falls under the "easy fix" purview of rust-lang/rfcs#1105, so I think that this is fine to go through.

@bors: r+ d0fc35f

@klutzy

klutzy commented May 18, 2015

Copy link
Copy Markdown
Contributor Author

Yep, I think this is the case of "Minor change: introducing new lint warnings/errors" of the RFC. This patch was made since a Rust beginner misused #[packed] but compiler didn't make a warning.

@bors

bors commented May 18, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit d0fc35f with merge 8a8583c...

bors added a commit that referenced this pull request May 18, 2015
@bors

bors commented May 18, 2015

Copy link
Copy Markdown
Collaborator

@bors
bors merged commit d0fc35f into rust-lang:master May 18, 2015
@klutzy
klutzy deleted the remove-packed-attr branch May 18, 2015 03:25
liamsi added a commit to liamsi/qmlrs that referenced this pull request Jun 13, 2015
@brson brson added regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. relnotes Marks issues that should be documented in the release notes of the next release. labels Jul 13, 2015
@brson

brson commented Jul 13, 2015

Copy link
Copy Markdown
Contributor

As mentioned here this causes stable regressions with crates that were using the #[packed] attribute.

steveklabnik added a commit to steveklabnik/libnetfilter_queue that referenced this pull request Jul 21, 2015
AnIrishDuck added a commit to AnIrishDuck/rusty-prism that referenced this pull request Nov 13, 2015
fsck pushed a commit to fsck/libnetfilter_queue that referenced this pull request Oct 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. relnotes Marks issues that should be documented in the release notes of the next release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants